Switch to declarative KvConfig mapping #52
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previous imperative approach didn't allow for defining the reverse mapping from server configs to client configs Part of #33
ncoghlan
commented
Mar 18, 2025
| "disabledGpus": [1, 2], | ||
| }, | ||
| }, | ||
| {"key": "embedding.load.llama.keepModelInMemory", "value": True}, |
There was a problem hiding this comment.
The actual config contents are unchanged, but the order of the fields is different due to an iteration order change when processing the client config fields. The new ordering means that the fields will mostly be in alphabetical order by config key name on the wire, except when one client config maps to multiple KvConfig fields (in which case those fields will all be grouped together).
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous imperative approach didn't allow for defining the reverse mapping from server configs to client configs
Part of #33