Fix broken Bionic Reading #1588
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nyagami
approved these changes
Sep 21, 2025
CD-Z
pushed a commit
to CD-Z/lnreader
that referenced
this pull request
Oct 9, 2025
fix broken Bionic Reading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was broken with the last pr. Somehow the dev(bionic reading developer) who accepted the very same changes didnt find problems with the very same regex improvements.
I tested on LNReader, and adding a single group fixes the Bionic Reading feature.
Github comparison doesnt show, but I just made this simple change:
↓↓which fixed it.
Edit: the bionic reading script used on the app is an older version (or a modified one, i cant tell). That's why the original changes worked for the script creator, but not on the app ( I assume).