refactor(reader): move TTS handling from WebView to native layer#1710
Open
Avinash99b wants to merge 2 commits intolnreader:masterfrom
Open
refactor(reader): move TTS handling from WebView to native layer#1710Avinash99b wants to merge 2 commits intolnreader:masterfrom
Avinash99b wants to merge 2 commits intolnreader:masterfrom
Conversation
Fixes an Android build failure caused by duplicate class definitions introduced via app-level Gradle configuration. This change adjusts android/app/build.gradle to remove conflicting dependencies and ensure a successful release build. The issue surfaced during release builds and was not caught in debug-only verification.
Moved text-to-speech (TTS) handling from WebView JavaScript to a native React Native implementation. The previous WebView-based approach tightly coupled rendering and audio logic, making playback control, background handling, and state management unreliable and difficult to maintain. By shifting TTS to the native layer, the reader now has clearer separation of concerns, more stable playback, and improved maintainability while preserving the existing WebView-based reading UI.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves TTS logic from WebView JavaScript to a native React Native
implementation to improve playback reliability, background handling,
and separation of concerns while keeping the existing reader UI intact.