Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@iBenzene
Copy link
Contributor

@iBenzene iBenzene commented Jan 28, 2026

πŸ’» Change Type

  • ✨ feat
  • πŸ› fix
  • ♻️ refactor
  • πŸ’„ style
  • πŸ‘· build
  • ⚑️ perf
  • βœ… test
  • πŸ“ docs
  • πŸ”¨ chore

πŸ”— Related Issue

πŸ”€ Description of Change

Currently, the model IDs defined in the ZenMux configuration (zenmux.ts) do not include the required provider prefix.
For example, model IDs are specified as:

  • gpt-5.2

instead of the expected fully-qualified format:

  • openai/gpt-5.2

As a result, the routing layer cannot reliably determine the underlying provider for these models, which may lead to incorrect provider resolution or failed requests.

This PR addresses the issue by:

  • Adding the appropriate provider/ prefix (e.g. openai/) to all applicable ZenMux model IDs.
  • Cleaning up and normalizing the GPT-5.2 Chat model configuration to ensure consistency with the updated naming scheme.
  • Ensuring that ZenMux can correctly route requests based on fully-qualified model identifiers.

πŸ§ͺ How to Test

  • Start the application with the updated ZenMux configuration.

  • Verify that model routing correctly resolves the provider for prefixed model IDs (e.g. openai/gpt-5.2).

  • Send test requests to GPT-5.2 Chat models and confirm that requests are routed to the correct provider without errors.

  • Tested locally

  • Added/updated tests

  • No tests needed

πŸ“Έ Screenshots / Videos

N/A (no UI changes)

πŸ“ Additional Information

Summary by Sourcery

Update ZenMux chat model identifiers to use fully-qualified provider-prefixed IDs for GPT-5.2 variants and align the GPT-5.2 Chat metadata with the new naming.

Bug Fixes:

  • Ensure ZenMux GPT-5.2, GPT-5.2 Pro, and GPT-5.2 Chat models use provider-prefixed IDs so routing can correctly resolve the underlying provider.

Enhancements:

  • Simplify the GPT-5.2 Chat model description and normalize its identifier to match the updated naming scheme.

@vercel
Copy link

vercel bot commented Jan 28, 2026

@iBenzene is attempting to deploy a commit to the LobeHub OSS Team on Vercel.

A member of the Team first needs to authorize it.

@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Jan 28, 2026

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Updates ZenMux GPT-5.2 model configurations to use fully-qualified provider-prefixed model IDs and normalizes the GPT-5.2 Chat entry for consistent routing and naming.

Sequence diagram for ZenMux routing with provider-prefixed model IDs

sequenceDiagram
  actor Client
  participant RoutingLayer
  participant ZenMuxModelBank
  participant OpenAIProvider

  Client->>RoutingLayer: sendRequest(modelId: openai/gpt-5.2, payload)
  RoutingLayer->>ZenMuxModelBank: resolveModelCard(modelId: openai/gpt-5.2)
  ZenMuxModelBank-->>RoutingLayer: AIChatModelCard(provider: openai, id: openai/gpt-5.2)
  RoutingLayer->>OpenAIProvider: forwardRequest(modelId: gpt-5.2, payload)
  OpenAIProvider-->>RoutingLayer: response
  RoutingLayer-->>Client: response

  Client->>RoutingLayer: sendRequest(modelId: openai/gpt-5.2-chat, payload)
  RoutingLayer->>ZenMuxModelBank: resolveModelCard(modelId: openai/gpt-5.2-chat)
  ZenMuxModelBank-->>RoutingLayer: AIChatModelCard(provider: openai, id: openai/gpt-5.2-chat)
  RoutingLayer->>OpenAIProvider: forwardRequest(modelId: gpt-5.2-chat, payload)
  OpenAIProvider-->>RoutingLayer: response
  RoutingLayer-->>Client: response
Loading

Class diagram for updated ZenMux GPT-5.2 chat model configurations

classDiagram
  class AIChatModelCard {
    +string id
    +string displayName
    +string description
    +boolean enabled
    +number maxOutput
    +number contextWindowTokens
  }

  class GPT_5_2_Flagship {
    +id = openai/gpt-5.2
    +displayName = GPT-5.2
    +description = GPT-5.2 is a flagship model for coding and agentic workflows with stronger reasoning and long-context performance.
    +enabled = true
    +maxOutput = 128000
  }

  class GPT_5_2_Pro {
    +id = openai/gpt-5.2-pro
    +displayName = GPT-5.2 pro
    +description = GPT-5.2 Pro: a smarter, more precise GPT-5.2 variant (Responses API only), suited for harder problems and longer multi-turn reasoning.
    +enabled = true
    +maxOutput = 128000
  }

  class GPT_5_2_Chat {
    +id = openai/gpt-5.2-chat
    +displayName = GPT-5.2 Chat
    +description = GPT-5.2 Chat is the ChatGPT variant for experiencing the newest conversation improvements.
    +enabled = true
    +maxOutput = 16384
    +contextWindowTokens = 128000
  }

  AIChatModelCard <|-- GPT_5_2_Flagship
  AIChatModelCard <|-- GPT_5_2_Pro
  AIChatModelCard <|-- GPT_5_2_Chat
Loading

File-Level Changes

Change Details Files
Prefix ZenMux GPT-5.2 model IDs with the OpenAI provider and normalize the GPT-5.2 Chat configuration.
  • Change GPT-5.2 base model ID to use the fully-qualified openai/gpt-5.2 identifier.
  • Change GPT-5.2 Pro model ID to use the fully-qualified openai/gpt-5.2-pro identifier.
  • Update GPT-5.2 Chat description text to remove the obsolete chat-latest reference.
  • Rename GPT-5.2 Chat model ID from gpt-5.2-chat-latest to the fully-qualified openai/gpt-5.2-chat identifier.
packages/model-bank/src/aiModels/zenmux.ts

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@gru-agent
Copy link
Contributor

gru-agent bot commented Jan 28, 2026

TestGru Assignment

Summary

Link CommitId Status Reason
Detail b7760c4 🚫 Skipped No files need to be tested {"packages/model-bank/src/aiModels/zenmux.ts":"source code too long"}

History Assignment

Tip

You can @gru-agent and leave your feedback. TestGru will make adjustments based on your input

@iBenzene iBenzene changed the title fix(model-bank): fix ZenMux model IDs by adding provider prefixes πŸ› fix(model-bank): fix ZenMux model IDs by adding provider prefixes Jan 28, 2026
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've left some high level feedback:

  • Since the GPT-5.2 Chat ID changed from gpt-5.2-chat-latest to openai/gpt-5.2-chat, double-check any consumers that may still be referencing the old ID (e.g., routing config, presets, or feature flags) and consider providing a backward-compatible alias if those references are external or hard to update.
  • If provider prefixes like openai/ are used in multiple places, it may be worth centralizing them (e.g., as a constant or enum) to avoid divergence if provider naming ever changes.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- Since the GPT-5.2 Chat ID changed from `gpt-5.2-chat-latest` to `openai/gpt-5.2-chat`, double-check any consumers that may still be referencing the old ID (e.g., routing config, presets, or feature flags) and consider providing a backward-compatible alias if those references are external or hard to update.
- If provider prefixes like `openai/` are used in multiple places, it may be worth centralizing them (e.g., as a constant or enum) to avoid divergence if provider naming ever changes.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click πŸ‘ or πŸ‘Ž on each comment and I'll use the feedback to improve your reviews.

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

πŸ’‘ Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: b7760c40ef

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with πŸ‘.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

@arvinxx arvinxx merged commit 17f8a5c into lobehub:main Jan 29, 2026
15 of 17 checks passed
@lobehubbot
Copy link
Member

❀️ Great PR @iBenzene ❀️

The growth of project is inseparable from user feedback and contribution, thanks for your contribution! If you are interesting with the lobehub developer community, please join our discord and then dm @arvinxx or @canisminor1990. They will invite you to our private developer channel. We are talking about the lobe-chat development or sharing ai newsletter around the world.

lobehubbot pushed a commit that referenced this pull request Jan 29, 2026
### [Version&nbsp;2.0.9](v2.0.8...v2.0.9)
<sup>Released on **2026-01-29**</sup>

#### πŸ› Bug Fixes

- **model-bank**: Fix ZenMux model IDs by adding provider prefixes.

<br/>

<details>
<summary><kbd>Improvements and Fixes</kbd></summary>

#### What's fixed

* **model-bank**: Fix ZenMux model IDs by adding provider prefixes, closes [#11947](#11947) ([17f8a5c](17f8a5c))

</details>

<div align="right">

[![](https://img.shields.io/badge/-BACK_TO_TOP-151515?style=flat-square)](#readme-top)

</div>
@lobehubbot
Copy link
Member

πŸŽ‰ This PR is included in version 2.0.9 πŸŽ‰

The release is available on:

Your semantic-release bot πŸ“¦πŸš€

JamieStivala pushed a commit to jaworldwideorg/OneJA-Bot that referenced this pull request Jan 29, 2026
### [Version&nbsp;1.157.1](v1.157.0...v1.157.1)
<sup>Released on **2026-01-29**</sup>

#### πŸ› Bug Fixes

- **model-bank**: Fix ZenMux model IDs by adding provider prefixes.
- **misc**: Add ExtendParamsTypeSchema for enhanced model settings.

#### πŸ’„ Styles

- **misc**: Fix group task render.

<br/>

<details>
<summary><kbd>Improvements and Fixes</kbd></summary>

#### What's fixed

* **model-bank**: Fix ZenMux model IDs by adding provider prefixes, closes [lobehub#11947](https://github.com/jaworldwideorg/OneJA-Bot/issues/11947) ([17f8a5c](17f8a5c))
* **misc**: Add ExtendParamsTypeSchema for enhanced model settings, closes [lobehub#11437](https://github.com/jaworldwideorg/OneJA-Bot/issues/11437) ([f58c980](f58c980))

#### Styles

* **misc**: Fix group task render, closes [lobehub#11952](https://github.com/jaworldwideorg/OneJA-Bot/issues/11952) ([b8ef02e](b8ef02e))

</details>

<div align="right">

[![](https://img.shields.io/badge/-BACK_TO_TOP-151515?style=flat-square)](#readme-top)

</div>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants