This repository was archived by the owner on Jul 9, 2025. It is now read-only.
Major: rename default container name to localstack-main #892
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🎊 PR Preview has been successfully built and deployed to https://localstack-docs-preview-pr-892.surge.sh 🎊 |
7036c46 to
a6c0e68
Compare
dominikschubert
approved these changes
Nov 8, 2023
There was a problem hiding this comment.
LGTM!
@simonrw Before merging please look over the added docker-compose sample and adjust it if you see any issues.
86354dd to
27afd5f
Compare
The previous default container name `localstack_main` is not a valid URL, so we rename the default to `localstack-main`. See localstack/localstack#9469.
Co-authored-by: Dominik Schubert <[email protected]>
0344514 to
37b5c12
Compare
|
I think the |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Underscores are not allowed in URLs, but hyphens are. When addressing the LocalStack container over a docker network, the container name resolves to the IP address of the container. This is a problem in particular for boto3 which refuses to connect.
Changes
This PR updates usages of
localstack_maintolocalstack-main.