move aws-specific patches into localstack.aws.patches #10958
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
S3 Image Test Results (AMD64 / ARM64) 2 files 2 suites 3m 10s ⏱️ Results for commit 1b15e68. |
dominikschubert
approved these changes
Jun 4, 2024
Comment on lines
+45
to
+46
| # TODO: this could be improved by introducing a hook specifically for applying global patches that is run | ||
| # before any other code is imported. |
There was a problem hiding this comment.
good idea, that would make it a lot more explicit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
As part of the effort to reduce coupling of runtime and AWS code #10946, I'm moving some patches that are specific to moto AWS into their own package, and applying them using a hook rather than statically in the infra code. This will also help in #10942.
I left some parts of the
patch_moto_request_handlingbecause I'd like to separately investigate whether we can simplify or remove it.Changes
patch_instance_tracker_metais now applied using a hookload_aws_managed_policiesis now done in its own patch