fix flaky new DDB test #10973
Merged
fix flaky new DDB test #10973
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexrashed
approved these changes
Jun 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
As seen in this run, the ARM test failed for
test_dynamodb_stream_records_with_update_item.This looks like it can be due to parallel request being processed and not leaving the time to DynamoDB to properly ingest the first item (so it does not return it when looking if the object already exists when "updating" the item with the second call).
This is a race condition, DynamoDB has a somewhat eventual consistency, so maybe this can happen in AWS, or this could be treated as a race condition/bug in LocalStack, but we do not have a real way of preventing it for now. At least the test is more robust now.
Changes