CFn v2: Implement stack deletion #12576
Draft
+119
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LocalStack Community integration with Pro 2 files 2 suites 21m 37s ⏱️ Results for commit dc764a7. ♻️ This comment has been updated with latest results. |
a459112 to
36039d4
Compare
60db6f4 to
ac56fa8
Compare
This should work but I don't know why it doesn't
ac56fa8 to
dc764a7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Quite a few resource tests fail because the deletion of a stack is not correctly implemented. The tests assert that resources are deleted, but they aren't.
Changes
Nonein for theaftertemplate and parameterstest_deletion.pytest, but I don't know why it fails right nowTesting
In addition to the included test, run the test
tests/aws/services/cloudformation/resources/test_events.py::test_cfn_event_bus_resourcewhich fails on the master branch.