Thanks to visit codestin.com
Credit goes to github.com

Skip to content

CFn v2: better handle deploy errors #12601

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 12, 2025
Merged

CFn v2: better handle deploy errors #12601

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 20 additions & 9 deletions localstack-core/localstack/services/cloudformation/v2/provider.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -271,15 +271,26 @@ def execute_change_set(
)

def _run(*args):
result = change_set_executor.execute()
new_stack_status = StackStatus.UPDATE_COMPLETE
if change_set.change_set_type == ChangeSetType.CREATE:
new_stack_status = StackStatus.CREATE_COMPLETE
change_set.stack.set_stack_status(new_stack_status)
change_set.set_execution_status(ExecutionStatus.EXECUTE_COMPLETE)
change_set.stack.resolved_resources = result.resources
change_set.stack.resolved_parameters = result.parameters
change_set.stack.resolved_outputs = result.outputs
try:
result = change_set_executor.execute()
new_stack_status = StackStatus.UPDATE_COMPLETE
if change_set.change_set_type == ChangeSetType.CREATE:
new_stack_status = StackStatus.CREATE_COMPLETE
change_set.stack.set_stack_status(new_stack_status)
change_set.set_execution_status(ExecutionStatus.EXECUTE_COMPLETE)
change_set.stack.resolved_resources = result.resources
change_set.stack.resolved_parameters = result.parameters
change_set.stack.resolved_outputs = result.outputs
except Exception as e:
LOG.error(
"Execute change set failed: %s", e, exc_info=LOG.isEnabledFor(logging.WARNING)
)
new_stack_status = StackStatus.UPDATE_FAILED
if change_set.change_set_type == ChangeSetType.CREATE:
new_stack_status = StackStatus.CREATE_FAILED

change_set.stack.set_stack_status(new_stack_status)
change_set.set_execution_status(ExecutionStatus.EXECUTE_FAILED)

start_worker_thread(_run)

Expand Down
Loading