Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Add KMS ReEncrypt Operation #12637

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 25 commits into from
Jun 20, 2025
Merged

Add KMS ReEncrypt Operation #12637

merged 25 commits into from
Jun 20, 2025

Conversation

victor-martin-santiago
Copy link
Contributor

Motivation

I'm creating this PR to add the implementation for the KMS ReEncrypt operation.

Changes

Adds an implementation for KMS ReEncrypt operation, based on the already existing Encrypt and Decrypt operations,

Testing

The changes have been covered by integration & AWS parity tests.

Optionally, the ReEncrypt operation can be tested using the below aws cli command

aws kms re-encrypt \
	--endpoint-ur=http://localhost:4566 \
	--ciphertext-blob="$encriptedText" \
	--destination-key-id=$destinationKeyId \
	--source-key-id=$sourceKeyId

@localstack-bot
Copy link
Collaborator

localstack-bot commented May 19, 2025 •
edited
Loading

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

localstack-bot
localstack-bot reviewed May 19, 2025
View reviewed changes
Copy link
Collaborator

@localstack-bot localstack-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to LocalStack! Thanks for raising your first Pull Request and landing in your contributions. Our team will reach out with any reviews or feedbacks that we have shortly. We recommend joining our Slack Community and share your PR on the #community channel to share your contributions with us. Please make sure you are following our contributing guidelines and our Code of Conduct.

@victor-martin-santiago victor-martin-santiago changed the title Add KMS Re-encrypt Operation Add KMS ReEncrypt Operation May 19, 2025
@victor-martin-santiago victor-martin-santiago marked this pull request as ready for review May 19, 2025 09:38
@victor-martin-santiago
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@victor-martin-santiago
Copy link
Contributor Author

recheck

localstack-bot added a commit that referenced this pull request May 19, 2025
@localstack-bot
@victormartinsantiago has signed the CLA in #12637
ff9becf
@viren-nadkarni viren-nadkarni added the semver: minor Non-breaking changes which can be included in minor releases, but not in patch releases label May 19, 2025
@viren-nadkarni viren-nadkarni self-requested a review May 20, 2025 08:05
viren-nadkarni
viren-nadkarni reviewed May 20, 2025
View reviewed changes
Copy link
Member

@viren-nadkarni viren-nadkarni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for raising the PR!

It looks good overall, I have only some small points

sannya-singal
sannya-singal reviewed May 21, 2025
View reviewed changes
Copy link
Contributor

@sannya-singal sannya-singal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work on implementing the ReEncrypt operation for KMS! 🚀

I just have few suggestions to further enhance the parity with AWS by adding a check for verifying the KeyUsage. Once that’s in place, we can do a quick re-review and move forward with merging the PR 🎉 Thank you 🙌

@tiurin tiurin added this to the Playground milestone Jun 4, 2025
sannya-singal
sannya-singal reviewed Jun 9, 2025
View reviewed changes
sannya-singal
sannya-singal reviewed Jun 9, 2025
View reviewed changes
sannya-singal
sannya-singal reviewed Jun 9, 2025
View reviewed changes
sannya-singal
sannya-singal reviewed Jun 10, 2025
View reviewed changes
sannya-singal
sannya-singal reviewed Jun 10, 2025
View reviewed changes
sannya-singal
sannya-singal reviewed Jun 10, 2025
View reviewed changes
@victor-martin-santiago
Copy link
Contributor Author

@sannya-singal not sure where the Error: Username and password required errors are coming from, on the integration/acceptance tests

@sannya-singal
Copy link
Contributor

@victor-martin-santiago could you please rebase your branch to master ?

@victor-martin-santiago
Copy link
Contributor Author

@victor-martin-santiago could you please rebase your branch to master ?

Done!

@sannya-singal
Copy link
Contributor

Thanks for reporting this @victor-martin-santiago, we are looking into this and should be fixed shortly 🙌

@victor-martin-santiago
Copy link
Contributor Author

Thanks for the heads up @sannya-singal !

@sannya-singal
Copy link
Contributor

Hey @victor-martin-santiago, we have merged the fix for the issue, rebasing the branch should now resolve the issue. Thank you 🙌

@victor-martin-santiago
Copy link
Contributor Author

Hey @sannya-singal , branch has been updated!

@sannya-singal sannya-singal merged commit 6348947 into localstack:master Jun 20, 2025
34 checks passed
@victor-martin-santiago
Copy link
Contributor Author

❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@viren-nadkarni viren-nadkarni viren-nadkarni left review comments

@localstack-bot localstack-bot localstack-bot left review comments

@sannya-singal sannya-singal sannya-singal approved these changes

Assignees

@victor-martin-santiago victor-martin-santiago

Labels
semver: minor Non-breaking changes which can be included in minor releases, but not in patch releases
Projects
None yet
Milestone
Playground
Development

Successfully merging this pull request may close these issues.
5 participants
@victor-martin-santiago @localstack-bot @sannya-singal @viren-nadkarni @tiurin