-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
CloudFormation v2 Engine: Base Support for Fn::GetAZs #12699
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
8f14387
base support for dependson and apigw test unlock
MEPalma 2bfc135
base support for fn sub
MEPalma 648fcf1
Merge branch 'master' into MEP-CFN-fn_sub
MEPalma 66937e0
v1 tests port, test annotations, batch of parity improvements
MEPalma 75d12d6
base support for fn::transform
MEPalma 47a0a1a
typing migration, change types compute, unskip
MEPalma 653122e
None bindins prune the value
MEPalma bcb65f2
minor
MEPalma 52008ee
minor
MEPalma 795d3a0
support for fn::select
MEPalma 2833ff3
tests
MEPalma f55f012
split tests
MEPalma 498c08b
base support for split
MEPalma 0b969ee
init support for getazs
MEPalma 33243fb
cleanup and empty region field
MEPalma 08dec8f
conflicts
MEPalma a465e2f
cleanup
MEPalma 3b96037
Merge branch 'MEP-CFN-fn_split' into MEP-CFN-fn_getazs
MEPalma 5f014c9
missing type hint
MEPalma fc4ea60
pr item
MEPalma 82ca923
conflicts
MEPalma File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -70,7 +70,7 @@ def test_simple_route_table_creation(deploy_cfn_template, aws_client, snapshot): | |
# ec2.describe_route_tables(RouteTableIds=[route_table_id]) | ||
|
||
|
||
@pytest.mark.skip(reason="CFNV2:Fn::Select, CFNV2:Fn::GatAZs") | ||
@pytest.mark.skip(reason="CFNV2:Other") | ||
@markers.aws.validated | ||
def test_vpc_creates_default_sg(deploy_cfn_template, aws_client): | ||
result = deploy_cfn_template( | ||
|
@@ -109,7 +109,6 @@ def test_cfn_with_multiple_route_tables(deploy_cfn_template, aws_client): | |
assert len(resp["RouteTables"]) == 4 | ||
|
||
|
||
@pytest.mark.skip(reason="CFNV2:Fn::Select, CFNV2:Fn::GatAZs") | ||
@markers.aws.validated | ||
@markers.snapshot.skip_snapshot_verify( | ||
paths=["$..PropagatingVgws", "$..Tags", "$..Tags..Key", "$..Tags..Value"] | ||
|
@@ -165,7 +164,6 @@ def test_dhcp_options(aws_client, deploy_cfn_template, snapshot): | |
snapshot.match("description", response["DhcpOptions"][0]) | ||
|
||
|
||
@pytest.mark.skip(reason="CFNV2:Fn::Select, CFNV2:Fn::GatAZs") | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🎉 |
||
@markers.aws.validated | ||
@markers.snapshot.skip_snapshot_verify( | ||
paths=[ | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -197,7 +197,6 @@ def test_cidr_function(self, deploy_cfn_template): | |
|
||
assert deployed.outputs["Address"] == "10.0.0.0/24" | ||
|
||
@pytest.mark.skip(reason="CFNV2:Fn::GetAZs") | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🎉 |
||
@pytest.mark.parametrize( | ||
"region", | ||
[ | ||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉