Thanks to visit codestin.com
Credit goes to github.com

Skip to content

refactor: reduce max number of allowed labels in counters from 8 to 6 [DAT-146] #12704

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 3, 2025
Merged

refactor: reduce max number of allowed labels in counters from 8 to 6 [DAT-146] #12704

merged 1 commit into from
Jun 3, 2025

Conversation

vittoriopolverino
Copy link
Member

@vittoriopolverino vittoriopolverino commented Jun 3, 2025 •
edited
Loading

Motivation

  • After reviewing label usage over the past few months, we found that no existing metric uses more than 5 labels.
  • Limiting counters to 6 labels help to avoid overly complex metrics that try to capture too many different aspects.
  • Fewer labels simplify analytics query and makes dashboards easier to build/read.
  • A limit of 6 is sufficiently high for current needs, but this threshold can be revisited in the future if necessary.

Changes

@vittoriopolverino vittoriopolverino self-assigned this Jun 3, 2025
@vittoriopolverino vittoriopolverino added the semver: patch Non-breaking changes which can be included in patch releases label Jun 3, 2025
@vittoriopolverino vittoriopolverino added this to the 4.5 milestone Jun 3, 2025
@vittoriopolverino vittoriopolverino requested a review from joe4dev June 3, 2025 11:33
@vittoriopolverino
Copy link
Member Author

@joe4dev not sure who to tag for review. I used to loop in Alex, but he's on leave. Hope you don’t mind! The change is quite minimal 🙏🏼

@vittoriopolverino vittoriopolverino marked this pull request as ready for review June 3, 2025 11:35
@vittoriopolverino vittoriopolverino requested a review from thrau as a code owner June 3, 2025 11:35
@vittoriopolverino vittoriopolverino requested a review from ackdav June 3, 2025 11:36
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 3, 2025

Test Results - Preflight, Unit

21 595 tests  ±0   19 940 ✅ ±0   6m 36s ⏱️ +21s
     1 suites ±0    1 655 💤 ±0 
     1 files   ±0        0 ❌ ±0 

Results for commit ee262ef. ± Comparison against base commit 0b05553.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 3, 2025

Test Results (amd64) - Acceptance

7 tests  ±0   5 ✅ ±0   3m 13s ⏱️ +4s
1 suites ±0   2 💤 ±0 
1 files   ±0   0 ❌ ±0 

Results for commit ee262ef. ± Comparison against base commit 0b05553.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 3, 2025

Test Results - Alternative Providers

977 tests   547 ✅  22m 6s ⏱️
  4 suites  430 💤
  4 files      0 ❌

Results for commit ee262ef.

joe4dev
joe4dev approved these changes Jun 3, 2025
View reviewed changes
Copy link
Member

@joe4dev joe4dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Limiting complexity makes a lot of sense 👍

ackdav
ackdav approved these changes Jun 3, 2025
View reviewed changes
Copy link
Member

@ackdav ackdav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 3, 2025

Test Results (amd64) - Integration, Bootstrap

    5 files      5 suites   2h 21m 18s ⏱️
5 216 tests 4 297 ✅ 919 💤 0 ❌
5 222 runs  4 297 ✅ 925 💤 0 ❌

Results for commit ee262ef.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 3, 2025

LocalStack Community integration with Pro

    2 files  ±0      2 suites  ±0   1h 43m 13s ⏱️ +31s
4 861 tests ±0  4 094 ✅ ±0  767 💤 ±0  0 ❌ ±0 
4 863 runs  ±0  4 094 ✅ ±0  769 💤 ±0  0 ❌ ±0 

Results for commit ee262ef. ± Comparison against base commit 0b05553.

@vittoriopolverino vittoriopolverino merged commit a7a7b5f into master Jun 3, 2025
62 checks passed
@vittoriopolverino vittoriopolverino deleted the DAT-146-reduce-max-allowed-labels-in-counter branch June 3, 2025 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ackdav ackdav ackdav approved these changes

@joe4dev joe4dev joe4dev approved these changes

@thrau thrau Awaiting requested review from thrau thrau is a code owner

Assignees

@vittoriopolverino vittoriopolverino

Labels
semver: patch Non-breaking changes which can be included in patch releases
Projects
None yet
Milestone
4.5
Development

Successfully merging this pull request may close these issues.
3 participants
@vittoriopolverino @ackdav @joe4dev