test(esm/sqs): Skip flaky test_report_batch_item_failures test #12713
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anisaoshafi
approved these changes
Jun 4, 2025
joe4dev
approved these changes
Jun 4, 2025
| @@ -538,6 +541,7 @@ def test_report_batch_item_failures( | |||
| # now wait for the first invocation result which is expected to have processed message 1 we wait half the retry | |||
| # interval to wait long enough for the message to appear, but short enough to check that the DLQ is empty after | |||
| # the first attempt. | |||
| # FIXME: We cannot assume that the queue will always return a message in the given time-interval. | |||
There was a problem hiding this comment.
Maybe, we can use the collect sqs messages fixture doing retries. Good catch 👍
Test Results (amd64) - Acceptance7 tests 5 ✅ 3m 5s ⏱️ Results for commit 9563c88. |
Test Results - Alternative Providers986 tests 568 ✅ 22m 23s ⏱️ Results for commit 9563c88. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This test makes a faulty assumption that a
ReceiveMessagescall will always return a value. Skip for now but re-visit this test after release.Changes
tests/aws/services/lambda_/event_source_mapping/test_lambda_integration_sqs.py/test_report_batch_item_failures