Add provider info to service request counter #12740
Conversation
Test Results - Preflight, Unit21 613 tests ±0 19 956 ✅ - 2 6m 28s ⏱️ +15s For more details on these failures, see this check. Results for commit b6d93f4. ± Comparison against base commit 5b623bf. |
| @@ -42,13 +42,15 @@ def __call__(self, chain: HandlerChain, context: RequestContext, response: Respo | |||
| err_type = self._get_err_type(context, response) if response.status_code >= 400 else None | |||
| service_name = context.operation.service_model.service_name | |||
| operation_name = context.operation.name | |||
| provider = config.SERVICE_PROVIDER_CONFIG.get_provider(service_name) | |||
There was a problem hiding this comment.
this line seems to suggest that there's a 1:1 relationship of service_name to provider, which I think is not true - did I misread the function or the 1:1 relationship actually is true in the community version?
There was a problem hiding this comment.
In a running instance the relation is 1:1. Only one provider can be active at once. The active provider is defined in the config
There was a problem hiding this comment.
Thanks for taking a stab at this! My high-level feedback is: if we include the service provider in each service request, we'll also need to adapt the analytics backend, specifically the materialized view that stores the AWS service request. We can do that, but this creates additional work, is quite a substantial change. Also, since the set of providers doesn't (because it currently cannot) change during the runtime of LocalStack, we'll be sending redundant data for each request.
It might be more efficient to capture the configured providers once at startup, similar to how we log environment variables. This would avoid redundancy and keep the data leaner. Happy to provide more guidance if needed, but suggest to sync up with @vittoriopolverino on this
Just want some clarification on the "capture the configured providers once at startup" suggestion - do you mean at each session start, send a map of provider to service to the data backend, and let the data backend figure out the provider for each service within the session? |
Happy to support on this. +1 to what Thomas already pointed out |
Motivation
/cc @mmaureenliu
Changes