S3: fix Checksum handling in UploadPartCopy #12753
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We've got a report in our Community Slack with a small sample (as represented by the new test) where Checksum handling did not work well with the
UploadPartCopy
operation: https://docs.aws.amazon.com/AmazonS3/latest/API/API_UploadPartCopy.htmlThis was due because we simply did not handle checksums as this was not implemented in our previous implementation.
We now properly handle checksums when copying an object into a part, via our storage engine.
This was the error when calling
ListParts
:Changes
UploadPartCopy
ListParts
to avoid unhandled exceptions