-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
refactored archive installer #12771
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
macnev2013
wants to merge
3
commits into
master
Choose a base branch
from
bigdata-mirror
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
refactored archive installer #12771
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The
ArchiveDownloadAndExtractInstaller
class currently has some limitations that make it difficult to extend and reuse. The main issue is that the_install
method is handling multiple responsibilities(setting up directories, downloading archives, extracting files, and handling special cases like single-directory archives).This monolithic approach makes it hard for subclasses to customize specific parts of the installation process without having to rewrite the entire method.
This PR refactors the class to break down these responsibilities into smaller, focused methods that can be easily overridden or reused by subclasses.
Changes
_install
method_download_and_extract_archive
- downloads and extracts archive_handle_single_directory_extraction
- handles logic for extracting all files in a single root directorytry/finally
block