Stop pushing empty release commit for community #12880
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results (amd64) - Integration, Bootstrap 5 files 5 suites 2h 21m 16s ⏱️ For more details on these failures, see this check. Results for commit f545a3a. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
With the removal of CircleCI and #12829 we removed the need of having an empty commit to trigger the CI on releases of
localstack-coreandlocalstack/localstack.We can now proceed to trigger the pipeline purely via the tag on the latest commit in the
mainbranch.Changes
--allow-emptyin the release commitTesting
git commit -m "test"on a clean working tree just skips the creation of a commit. Subsequently runninggit tagwill then put it on the latest commit in the branch.TODO
What's left to do:
Decide whether we should remove--allow-emptyfor the development iteration branch as well or not. In theory this commit is also unnecessarylocalstack-proto depend on.