sqs: fix exception log message for sqs query execution #13007
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results (amd64) - Integration, Bootstrap 5 files 5 suites 1h 31m 27s ⏱️ Results for commit 4b2afd3. ♻️ This comment has been updated with latest results. |
LocalStack Community integration with Pro 2 files 2 suites 1h 3m 4s ⏱️ Results for commit 4b2afd3. ♻️ This comment has been updated with latest results. |
bentsku
approved these changes
Aug 14, 2025
580442b to
4b2afd3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Following up on the discussion here, this PR aims to improve the log message for executing SQS query operation. Previously, the error handling in the SQS request handler logged errors like this:
LOG.error("exception", exc_info=LOG.isEnabledFor(logging.DEBUG))while this ensured stack traces were only shown in debug mode, the actual log message
was not really useful.
Changes
This PR improves the logging message to include more context in the log ensuring that it carries useful information even when stack traces are suppressed when debug mode is disabled.