Thanks to visit codestin.com
Credit goes to github.com

Skip to content

ASF: implement CBOR parser and serializer #13103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 10 commits into
base: main
Choose a base branch
from
Draft

ASF: implement CBOR parser and serializer #13103

wants to merge 10 commits into from

Conversation

bentsku
Copy link
Contributor

@bentsku bentsku commented Sep 4, 2025 •
edited
Loading

Motivation

TBD

This is in preparation of adding support for smithy-rpc-v2-cbor, this is the first step in introducing a base CBOR serializer and parser. It could already be used in Kinesis when used similarly to the plain json protocol parser, and it was easier to test for now.

We still need to add the RPCV2 base parser and serializer, as well as the CBOR RPCV2 composites.

Changes

TBD

@bentsku bentsku added this to the 4.9 milestone Sep 4, 2025
@bentsku bentsku self-assigned this Sep 4, 2025
@bentsku bentsku added area: asf semver: minor Non-breaking changes which can be included in minor releases, but not in patch releases skip-docs Pull request does not require documentation changes labels Sep 4, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 4, 2025 •
edited
Loading

S3 Image Test Results (AMD64 / ARM64)

    2 files    2 suites   8m 28s ⏱️
  532 tests 480 ✅  52 💤 0 ❌
1 064 runs  960 ✅ 104 💤 0 ❌

Results for commit 9809182.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 4, 2025 •
edited
Loading

Test Results - Preflight, Unit

22 128 tests  +4   20 390 ✅ +4   6m 46s ⏱️ +21s
     1 suites ±0    1 738 💤 ±0 
     1 files   ±0        0 ❌ ±0 

Results for commit 9809182. ± Comparison against base commit aa8c1ba.

This pull request removes 4 and adds 8 tests. Note that renamed tests count towards both. 
tests.unit.aws.protocol.test_parser ‑ test_json_cbor_blob_parsing
tests.unit.aws.protocol.test_parser ‑ test_json_cbor_blob_parsing_w_timestamp
tests.unit.aws.protocol.test_serializer ‑ test_json_protocol_cbor_serialization[headers_dict0]
tests.unit.aws.protocol.test_serializer ‑ test_json_protocol_cbor_serialization[headers_dict1]

tests.unit.aws.protocol.test_parser ‑ test_json_cbor_blob_parsing[CBORRequestParser]
tests.unit.aws.protocol.test_parser ‑ test_json_cbor_blob_parsing[create_parser]
tests.unit.aws.protocol.test_parser ‑ test_json_cbor_blob_parsing_w_timestamp[CBORRequestParser]
tests.unit.aws.protocol.test_parser ‑ test_json_cbor_blob_parsing_w_timestamp[create_parser]
tests.unit.aws.protocol.test_serializer ‑ test_json_protocol_cbor_serialization[_cbor_serializer_factory-headers_dict0]
tests.unit.aws.protocol.test_serializer ‑ test_json_protocol_cbor_serialization[_cbor_serializer_factory-headers_dict1]
tests.unit.aws.protocol.test_serializer ‑ test_json_protocol_cbor_serialization[create_serializer-headers_dict0]
tests.unit.aws.protocol.test_serializer ‑ test_json_protocol_cbor_serialization[create_serializer-headers_dict1]

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 4, 2025 •
edited
Loading

Test Results (amd64) - Acceptance

7 tests  ±0   5 ✅ ±0   3m 14s ⏱️ -12s
1 suites ±0   2 💤 ±0 
1 files   ±0   0 ❌ ±0 

Results for commit 9809182. ± Comparison against base commit aa8c1ba.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 4, 2025 •
edited
Loading

Test Results (amd64) - Integration, Bootstrap

    5 files  ±0      5 suites  ±0   2h 34m 36s ⏱️ - 2m 26s
5 031 tests +2  4 540 ✅ +2  491 💤 ±0  0 ❌ ±0 
5 037 runs  +2  4 540 ✅ +2  497 💤 ±0  0 ❌ ±0 

Results for commit 9809182. ± Comparison against base commit aa8c1ba.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 4, 2025 •
edited
Loading

LocalStack Community integration with Pro

    2 files  ±0      2 suites  ±0   1h 55m 5s ⏱️ - 3m 41s
4 657 tests +2  4 326 ✅ +2  331 💤 ±0  0 ❌ ±0 
4 659 runs  +2  4 326 ✅ +2  333 💤 ±0  0 ❌ ±0 

Results for commit 9809182. ± Comparison against base commit aa8c1ba.

♻️ This comment has been updated with latest results.

@bentsku bentsku force-pushed the cbor-parser-serializer branch from 81df418 to 530069d Compare September 10, 2025 21:44
@localstack-bot
Copy link
Contributor

Currently, only patch changes are allowed on main. Your PR labels (area: asf, semver: minor, skip-docs) indicate that it cannot be merged into the main at this time.

@bentsku bentsku mentioned this pull request Sep 10, 2025
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexrashed alexrashed Awaiting requested review from alexrashed alexrashed will be requested when the pull request is marked ready for review alexrashed is a code owner

@thrau thrau Awaiting requested review from thrau thrau will be requested when the pull request is marked ready for review thrau is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@bentsku bentsku

Labels
area: asf semver: minor Non-breaking changes which can be included in minor releases, but not in patch releases skip-docs Pull request does not require documentation changes
Projects
None yet
Milestone
4.9
Development

Successfully merging this pull request may close these issues.
2 participants
@bentsku @localstack-bot