Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix response structure for Integration and IntegrationResponse #3245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Nov 19, 2020

Conversation

macnev2013
Copy link
Contributor

@macnev2013 macnev2013 commented Nov 14, 2020

This PR will fix response structure for Integration/IntegrationResponse
Improved Support for APIGateway in terraform

Refractored:

  • apigateway_models_Integration_init for backward compatibility
  • streamline patching pattern

Fixed:

  • APIGateway put_integration response
  • APIGateway put_integration_response response

Test:

  • Extended test case for improved response structure

This PR will address issue mentioned in #1984 .

┆Issue is synchronized with this Jira Bug by Unito

@macnev2013 macnev2013 requested a review from whummer November 14, 2020 14:40
@coveralls
Copy link

coveralls commented Nov 14, 2020

Coverage Status

Coverage increased (+0.09%) to 76.719% when pulling ff35c3b on macnev2013:fix-ag-tf into 83ff0cb on localstack:master.

@whummer
Copy link
Member

whummer commented Nov 16, 2020

Looks great, thanks @macnev2013 👍

@whummer whummer merged commit a1e6cf0 into localstack:master Nov 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants