Thanks to visit codestin.com
Credit goes to github.com

Skip to content

docs: add a pull request template #6084

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

docs: add a pull request template #6084

wants to merge 1 commit into from

Conversation

HarshCasper
Copy link
Member

Please refer to the contribution guidelines in the README when submitting PRs.

@HarshCasper HarshCasper temporarily deployed to localstack-ext-tests May 18, 2022 14:53 Inactive
@HarshCasper HarshCasper requested review from thrau and whummer May 18, 2022 14:53
@github-actions
Copy link

github-actions bot commented May 18, 2022 •
edited
Loading

LocalStack integration with Pro

       3 files  ±0         3 suites  ±0   1h 4m 15s ⏱️ - 1m 3s
1 054 tests ±0  1 021 ✔️ ±0  33 💤 ±0  0 ❌ ±0 
1 350 runs  ±0  1 290 ✔️ ±0  60 💤 ±0  0 ❌ ±0 

Results for commit 2bf239d. ± Comparison against base commit 8015c44.

♻️ This comment has been updated with latest results.

whummer
whummer reviewed May 19, 2022
View reviewed changes
Copy link
Member

@whummer whummer left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice steps towards a more structured PR template @HarshCasper ! 👍 Only added a few minor comments - will let others chime in as well.. 🙌

@HarshCasper HarshCasper temporarily deployed to localstack-ext-tests May 24, 2022 11:34 Inactive
@silv-io silv-io removed the size/s label Jun 13, 2022
@thrau thrau marked this pull request as draft June 30, 2022 09:05
@alexrashed alexrashed removed their request for review November 23, 2022 09:42
@thrau thrau closed this Feb 6, 2023
@thrau
Copy link
Member

thrau commented Feb 6, 2023

closing this PR as stale - i think we should re-visit the template at some point though.

@alexrashed alexrashed deleted the pr-template branch February 7, 2023 07:13
@thrau thrau mentioned this pull request Aug 5, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@whummer whummer whummer left review comments

@thrau thrau Awaiting requested review from thrau

@calvernaz calvernaz Awaiting requested review from calvernaz

@alexrashed alexrashed Awaiting requested review from alexrashed alexrashed will be requested when the pull request is marked ready for review alexrashed is a code owner

@dfangl dfangl Awaiting requested review from dfangl dfangl will be requested when the pull request is marked ready for review dfangl is a code owner

@dominikschubert dominikschubert Awaiting requested review from dominikschubert dominikschubert will be requested when the pull request is marked ready for review dominikschubert is a code owner

@silv-io silv-io Awaiting requested review from silv-io silv-io will be requested when the pull request is marked ready for review silv-io is a code owner

@k-a-il k-a-il Awaiting requested review from k-a-il k-a-il will be requested when the pull request is marked ready for review k-a-il is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@HarshCasper @thrau @whummer @silv-io