Added "oldImage" data to dynamo events reflecting deletions #640
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Adds the OldImage data so that when a listener of the dynamodb stream receives a deletion event, he's able to inspect the data that was deleted.
|
Great, thanks for this fix @Baccata ! |
Stovoy
pushed a commit
to Nextdoor/localstack
that referenced
this pull request
Feb 27, 2019
…ck#640) * Adds the OldImage data so that when a listener of the dynamodb stream receives a deletion event, he's able to inspect the data that was deleted.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the OldImage data so that when a listener of the dynamodb stream receives a deletion event, he's able to inspect the data that was deleted.
Apologies from the lack of tests, I'm not proficient in python and could not find a test I could easily mirror to test this fix. It was however working with my team's own integration tests.