Thanks to visit codestin.com
Credit goes to github.com

Skip to content

refactor s3 tests #6629

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 66 commits into from
Sep 7, 2022
Merged

refactor s3 tests #6629

merged 66 commits into from
Sep 7, 2022

Conversation

bentsku
Copy link
Contributor

@bentsku bentsku commented Aug 9, 2022

This is the initial PR for refactoring s3 tests, adding new ones corresponding to issues we could/would fix while migrating the service to ASF.

  • Migrated tests from integration/test_s3.py to integration/s3/test_s3.py
    • only a few left, where we still need to decide if migration makes sense - will takle during ASF s3 migration
  • Validated against AWS and added markers; added snapshots for appropriate tests
  • Added a few tests corresponding to opened issue, marked with xfail

@bentsku bentsku temporarily deployed to localstack-ext-tests August 9, 2022 15:27 Inactive
@coveralls
Copy link

coveralls commented Aug 9, 2022

Coverage Status

Coverage decreased (-0.0006%) to 91.476% when pulling bed9a21 on refactor-s3-tests into 27a4795 on master.

@github-actions
Copy link

github-actions bot commented Aug 9, 2022

LocalStack integration with Pro

       3 files  ±  0         3 suites  ±0   1h 15m 17s ⏱️ -49s
1 271 tests +15  1 219 ✔️ +5  52 💤 +10  0 ±0 
1 696 runs  +15  1 613 ✔️ +5  83 💤 +10  0 ±0 

Results for commit bed9a21. ± Comparison against base commit 27a4795.

♻️ This comment has been updated with latest results.

@bentsku bentsku force-pushed the refactor-s3-tests branch from 6ffd65f to 5a6b0c4 Compare August 19, 2022 15:54
@bentsku bentsku temporarily deployed to localstack-ext-tests August 19, 2022 15:54 Inactive
@bentsku bentsku temporarily deployed to localstack-ext-tests August 22, 2022 15:25 Inactive
@bentsku bentsku temporarily deployed to localstack-ext-tests August 22, 2022 16:07 Inactive
@steffyP steffyP temporarily deployed to localstack-ext-tests August 22, 2022 17:33 Inactive
@bentsku bentsku temporarily deployed to localstack-ext-tests August 22, 2022 17:59 Inactive
@bentsku bentsku temporarily deployed to localstack-ext-tests August 22, 2022 18:13 Inactive
@steffyP steffyP force-pushed the refactor-s3-tests branch from f41f628 to 1733726 Compare August 24, 2022 09:04
@steffyP steffyP temporarily deployed to localstack-ext-tests August 24, 2022 09:04 Inactive
@steffyP steffyP temporarily deployed to localstack-ext-tests August 24, 2022 17:10 Inactive
@bentsku bentsku force-pushed the refactor-s3-tests branch from c0bb683 to cbc0dc9 Compare August 25, 2022 23:17
@bentsku bentsku temporarily deployed to localstack-ext-tests August 25, 2022 23:20 Inactive
@bentsku bentsku temporarily deployed to localstack-ext-tests August 25, 2022 23:31 Inactive
@steffyP steffyP temporarily deployed to localstack-ext-tests August 26, 2022 14:49 Inactive
@bentsku bentsku temporarily deployed to localstack-ext-tests August 26, 2022 23:25 Inactive
@bentsku bentsku temporarily deployed to localstack-ext-tests August 29, 2022 08:29 Inactive
@bentsku bentsku temporarily deployed to localstack-ext-tests August 29, 2022 10:20 Inactive
@steffyP steffyP temporarily deployed to localstack-ext-tests August 29, 2022 12:18 Inactive
@bentsku bentsku temporarily deployed to localstack-ext-tests August 29, 2022 14:07 Inactive
@steffyP steffyP temporarily deployed to localstack-ext-tests September 1, 2022 09:27 Inactive
@steffyP steffyP temporarily deployed to localstack-ext-tests September 1, 2022 15:51 Inactive
@steffyP steffyP temporarily deployed to localstack-ext-tests September 2, 2022 12:51 Inactive
@steffyP steffyP temporarily deployed to localstack-ext-tests September 2, 2022 14:38 Inactive
@steffyP steffyP temporarily deployed to localstack-ext-tests September 2, 2022 15:39 Inactive
@steffyP steffyP temporarily deployed to localstack-ext-tests September 5, 2022 10:47 Inactive
bentsku and others added 24 commits September 6, 2022 16:43
…ressing and test_presigned_url_signature_authentication
@steffyP steffyP temporarily deployed to localstack-ext-tests September 6, 2022 15:44 Inactive
@steffyP steffyP temporarily deployed to localstack-ext-tests September 6, 2022 18:56 Inactive
@steffyP steffyP merged commit fb771a4 into master Sep 7, 2022
@steffyP steffyP deleted the refactor-s3-tests branch September 7, 2022 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants