replace s3 legacy rules with RestServiceOperationRouter #6839
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
First error: it sets the ServiceModel in request.context of |
d109a93 to
57191bb
Compare
21 tasks
|
Putting this back to the drafts, as changes will still happen to the router. We can reopen and make the necessary changes once things are set. |
add internal endpoints check
57191bb to
affa76c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on the migration of the s3 provider, @alexrashed provided us with a new rule for routing s3 requests, now that we can use the s3 specs, even if the default provider is still the currently used one and not ASF.
The s3 legacy routing rules are commented out to compare, we can safely delete them if RestServiceOperationRouter does the same job but better.
We only keep the host matching rule for now to correctly dispatch request containing the bucket in the host, as the path matching would not work.
The s3 test suite runs with this change, this PR will test it against the whole test suite.
Note: I will delete the commented part before merging