Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix terraform AWS provider patch for terraform tests #6853

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 12, 2022
Merged

fix terraform AWS provider patch for terraform tests #6853

merged 1 commit into from
Sep 12, 2022

Conversation

alexrashed
Copy link
Member

With 3baefea, @macnev2013 introduced an automation which automatically executes a set of terraform tests (created by the terraform community) against localstack.
The testing infrastructure depends on a small patch which is applied on top of https://github.com/hashicorp/terraform-provider-aws. Unfortunately, the patch broke with hashicorp/terraform-provider-aws@2b217fc.

This PR fixes the patch for now. In another iteration, we could make the testing infrastructure more resilient by:

  • Maybe get the terraform team to allow configuring the endpoints when executing the tests (that would be awesome).
  • Use a pinned version of the repo (i.e. a tag) which is automatically updated by some kind of "dependency bot" like renovate.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.008%) to 81.639% when pulling 32bc913 on fix-terraform-patch into 79b3b9d on master.

dominikschubert
dominikschubert approved these changes Sep 12, 2022
View reviewed changes
Copy link
Member

@dominikschubert dominikschubert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Having a way to configure these via environment variable for example would be great indeed 😄

@alexrashed alexrashed merged commit f42316e into master Sep 12, 2022
@alexrashed alexrashed deleted the fix-terraform-patch branch September 12, 2022 08:26
@alexrashed alexrashed mentioned this pull request Sep 12, 2022
Merged
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dominikschubert dominikschubert dominikschubert approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alexrashed @coveralls @dominikschubert