S3 ASF fix VersionId and Expires, implement ResponseHeaders override #6906
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
21 tasks
Merged
c1ca2bf to
13dcbdb
Compare
13dcbdb to
a5f876f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implement fixes to bugs that are also present in the current provider, coming from moto.
The VersionId would be present when it should not be, added logic to the versioning for that.
When
PutObjectwould be used with a pre-signed URL signed with SigV2, the object would be instantly expired because moto merges headers and query string parameters, and the signature contains anExpiresquery parameter which would be treated as theExpiresheader.It also implement the Response{Headers} overriding behaviour.