Thanks to visit codestin.com
Credit goes to github.com

Skip to content

implement S3 ASF website hosting support #6959

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 4, 2022
Merged

implement S3 ASF website hosting support #6959

merged 3 commits into from
Oct 4, 2022

Conversation

bentsku
Copy link
Contributor

@bentsku bentsku commented Oct 1, 2022

This PR implement support for S3 website hosting with additional features than the current provider.

Most S3 website features are now implemented, including RoutingRules, configuration validation...

https://docs.aws.amazon.com/AmazonS3/latest/userguide/WebsiteHosting.html

Note: permission/ACLs are not enforced currently, and it can be added in another PR with a feature flag in the same vein as IAM.

@bentsku bentsku temporarily deployed to localstack-ext-tests October 1, 2022 20:33 Inactive
@github-actions
Copy link

github-actions bot commented Oct 1, 2022

LocalStack integration with Pro

       3 files  +    2         3 suites  +2   1h 13m 45s ⏱️ + 20m 18s
1 350 tests +  27  1 219 ✔️ +  28  131 💤  -     1  0 ±0 
1 864 runs  +541  1 587 ✔️ +396  277 💤 +145  0 ±0 

Results for commit 0364ec8. ± Comparison against base commit f53cd51.

♻️ This comment has been updated with latest results.

@bentsku bentsku temporarily deployed to localstack-ext-tests October 3, 2022 18:24 Inactive
@bentsku bentsku marked this pull request as ready for review October 3, 2022 18:26
@bentsku bentsku requested a review from thrau as a code owner October 3, 2022 18:26
@bentsku bentsku temporarily deployed to localstack-ext-tests October 3, 2022 18:30 Inactive
@coveralls
Copy link

coveralls commented Oct 3, 2022

Coverage Status

Coverage decreased (-0.5%) to 78.621% when pulling 0364ec8 on s3-asf-website into f53cd51 on master.

@bentsku bentsku changed the title WIP: implement S3 ASF website hosting support implement S3 ASF website hosting support Oct 4, 2022
Copy link
Member

@thrau thrau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great @bentsku, congrats on making this work!

I only have a few minor comments, nothing blocking.

@bentsku bentsku temporarily deployed to localstack-ext-tests October 4, 2022 15:00 Inactive
@bentsku bentsku merged commit b2eebd8 into master Oct 4, 2022
@bentsku bentsku deleted the s3-asf-website branch October 4, 2022 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants