Thanks to visit codestin.com
Credit goes to github.com

Skip to content

S3 ASF test fixes #6987

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 10, 2022
Merged

S3 ASF test fixes #6987

merged 5 commits into from
Oct 10, 2022

Conversation

bentsku
Copy link
Contributor

@bentsku bentsku commented Oct 6, 2022

This PR implements the last small fixes to get the tests green in community.

  • Set the attributes stored in the S3Store to be CrossRegionAttribute, as a bucket can only be created in one region, and its configuration can be accessed from anywhere.
  • Fix notifications in case of a S3 pre-signed POST request (a bit of an ugly fix)
  • fix headers capitalization for S3 pre-signed URLs
  • return Location header in CompleteMultipartUpload response
  • fix tagging an object with an empty list
  • implement GetObjectAttributes operation, which is not implemented at all in moto (a mix of HeadObject and ListParts
  • fix non-caught exception when trying to get a deleted key in a versioned bucket
  • disable tests for the ASF S3 provider in test_edge.py that were related to S3 and the old proxy listener behaviour.
  • @dominikschubert fix a test in test_cloudformation_legacy.py: for s3 notifications configuration, when you set a target for notifications, S3 will check that the target exists by default. The provided ARN was computed using the region of the S3 bucket, but the actual queue was created in us-east-1 by CFn. Not sure what the expected behaviour was, but computing the ARN to match the actual created queue's ARN fixed the test.

@bentsku bentsku temporarily deployed to localstack-ext-tests October 6, 2022 21:01 Inactive
@github-actions
Copy link

github-actions bot commented Oct 6, 2022

LocalStack integration with Pro

       1 files   -     2         1 suites   - 2   50m 19s ⏱️ - 33m 12s
1 388 tests  -   15  1 196 ✔️  -   25  192 💤 +  10  0 ±0 
1 388 runs   - 613  1 196 ✔️  - 391  192 💤  - 222  0 ±0 

Results for commit 2a78b26. ± Comparison against base commit 472f457.

♻️ This comment has been updated with latest results.

@bentsku bentsku temporarily deployed to localstack-ext-tests October 7, 2022 09:05 Inactive
@bentsku bentsku changed the title WIP: S3 ASF test fixes S3 ASF test fixes Oct 10, 2022
@bentsku bentsku marked this pull request as ready for review October 10, 2022 09:35
@bentsku bentsku temporarily deployed to localstack-ext-tests October 10, 2022 09:36 Inactive
Copy link
Member

@thrau thrau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great set of changes! 🚀 so close now!!

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.04%) to 79.216% when pulling 2a78b26 on s3-asf-fix-tests into 472f457 on master.

Copy link
Member

@dominikschubert dominikschubert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Regarding test_cloudformation_legacy.py. They are as the name implies legacy tests that don't have a specific purpose right now. They'll either be rewritten or dropped fairly soon, so just making sure they're still green is fine in this instance 👍

@thrau thrau merged commit 079d5c0 into master Oct 10, 2022
@thrau thrau deleted the s3-asf-fix-tests branch October 10, 2022 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants