-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
S3 ASF test fixes #6987
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
S3 ASF test fixes #6987
Conversation
LocalStack integration with Pro 1 files - 2 1 suites - 2 50m 19s ⏱️ - 33m 12s Results for commit 2a78b26. ± Comparison against base commit 472f457. ♻️ This comment has been updated with latest results. |
93cecbf
to
2a78b26
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great set of changes! 🚀 so close now!!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Regarding test_cloudformation_legacy.py
. They are as the name implies legacy tests that don't have a specific purpose right now. They'll either be rewritten or dropped fairly soon, so just making sure they're still green is fine in this instance 👍
This PR implements the last small fixes to get the tests green in community.
S3Store
to beCrossRegionAttribute
, as a bucket can only be created in one region, and its configuration can be accessed from anywhere.Location
header inCompleteMultipartUpload
responseGetObjectAttributes
operation, which is not implemented at all in moto (a mix ofHeadObject
andListParts
test_edge.py
that were related to S3 and the old proxy listener behaviour.test_cloudformation_legacy.py
: for s3 notifications configuration, when you set a target for notifications, S3 will check that the target exists by default. The provided ARN was computed using the region of the S3 bucket, but the actual queue was created inus-east-1
by CFn. Not sure what the expected behaviour was, but computing the ARN to match the actual created queue's ARN fixed the test.