Add SQS integration support for new Lambda provider #7032
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
81c776b to
3775bd0
Compare
1789e31 to
05f9837
Compare
1ac37e6 to
09958be
Compare
thrau
approved these changes
Oct 20, 2022
There was a problem hiding this comment.
well done! i think this is a very nice solution for now, and it feels very much like the kind of things we had to do to make the edge proxy work with asf 😬
i fixed a circular import error that i noticed when testing, then everything worked fine!
i created this terraform sample to test the integration between lambda and sqs https://github.com/localstack/localstack-terraform-samples/tree/master/sns-sqs-subscription-lambda-trigger works perfectly with the new provider!
cmoralesmx
pushed a commit
to cmoralesmx/localstack
that referenced
this pull request
Oct 24, 2022
Co-authored-by: Thomas Rausch <[email protected]>
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More or less as shortcut to get parity with the old provider by re-using most of the event source mapping / DLQ constructs.
Changes:
Support for OnSuccess / OnFailure Destinations=> will come in a separate PR