Migrate lambda executor endpoints from flask to router #7039
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
739f081 to
c9d3e04
Compare
cmoralesmx
pushed a commit
to cmoralesmx/localstack
that referenced
this pull request
Oct 24, 2022
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We are currently spawning a new flask server for every runtime environment. This is both costly and cannot be shutdown easily, also in need of a lot of tcp ports which can lead to problems when not all ports are accessible from other containers.
Changes
The urls will therefore change from
{LOCALSTACK_IP}:{RANDOM_PORT}/...to{LOCALSTACK_IP}:{EDGE_PORT}/_localstack_lambda/{ENVIRONMENT_ID}/.... This can be done without needing to change the runtime init binary.Pair programming with @thrau