Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix internal botocore API usage #7086

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Dec 23, 2022
Merged

fix internal botocore API usage #7086

merged 11 commits into from
Dec 23, 2022

Conversation

alexrashed
Copy link
Member

@alexrashed alexrashed commented Oct 25, 2022 •
edited
Loading

boto/botocore recently changed the endpoint detection: boto/botocore@357d5a8
These changes (which are contained in botocore==1.28.0) break some of the internal APIs we are using for testing and for our forwarding API (because the endpoint parameter became mandatory).

This PR aims at adjusting to these changes.

@alexrashed alexrashed temporarily deployed to localstack-ext-tests October 25, 2022 08:46 Inactive
@alexrashed alexrashed marked this pull request as ready for review October 25, 2022 08:46
@alexrashed alexrashed requested a review from thrau as a code owner October 25, 2022 08:46
@alexrashed alexrashed temporarily deployed to localstack-ext-tests October 25, 2022 08:50 Inactive
@alexrashed alexrashed marked this pull request as draft October 25, 2022 08:56
@alexrashed alexrashed mentioned this pull request Oct 25, 2022
Merged
@github-actions
Copy link

github-actions bot commented Oct 25, 2022 •
edited
Loading

LocalStack integration with Pro

       3 files  ±0         3 suites  ±0   1h 24m 38s ⏱️ - 4m 49s
1 577 tests ±0  1 302 ✔️ ±0  275 💤 ±0  0 ❌ ±0 
2 223 runs  ±0  1 670 ✔️ ±0  553 💤 ±0  0 ❌ ±0 

Results for commit 3358550. ± Comparison against base commit 7c5e415.

♻️ This comment has been updated with latest results.

@thrau thrau force-pushed the fix-botocore-internal-api-usage branch from d59f6f3 to 9385166 Compare December 20, 2022 09:56
@thrau thrau temporarily deployed to localstack-ext-tests December 20, 2022 09:56 — with GitHub Actions Inactive
@steffyP steffyP temporarily deployed to localstack-ext-tests December 20, 2022 11:18 — with GitHub Actions Inactive
@steffyP steffyP force-pushed the fix-botocore-internal-api-usage branch from d0cb692 to 52c36f2 Compare December 22, 2022 13:55
@steffyP steffyP temporarily deployed to localstack-ext-tests December 22, 2022 13:55 — with GitHub Actions Inactive
@bentsku bentsku temporarily deployed to localstack-ext-tests December 22, 2022 19:09 — with GitHub Actions Inactive
@bentsku bentsku temporarily deployed to localstack-ext-tests December 22, 2022 19:46 — with GitHub Actions Inactive
@bentsku bentsku temporarily deployed to localstack-ext-tests December 22, 2022 19:48 — with GitHub Actions Inactive
@bentsku bentsku temporarily deployed to localstack-ext-tests December 22, 2022 20:25 — with GitHub Actions Inactive
@bentsku bentsku temporarily deployed to localstack-ext-tests December 22, 2022 22:17 — with GitHub Actions Inactive
@bentsku
Copy link
Contributor

bentsku commented Dec 22, 2022 •
edited
Loading

Most of the issue with S3 comes from the point that they now try to strip the {Bucket} from the requestUri, because it's actually not there in virtual host addressing mode. I've tried to work on quick fix to get it to work, as the pinning of botocore is starting to create more issues. I hope we can make it maybe cleaner.
I suppose they add the Bucket back in the path by using the new contextParam field in service-2.json when in path addressed mode.

We can see removing the bucket from requestUri in the operation model is intentional in this comment: boto/botocore@357d5a8#r90671876

@coveralls
Copy link

coveralls commented Dec 22, 2022 •
edited
Loading

Coverage Status

Coverage: 84.727% (-0.03%) from 84.761% when pulling 3358550 on fix-botocore-internal-api-usage into 7c5e415 on master.

@steffyP steffyP mentioned this pull request Dec 23, 2022
Merged
1 task
@alexrashed alexrashed temporarily deployed to localstack-ext-tests December 23, 2022 12:19 — with GitHub Actions Inactive
@alexrashed alexrashed force-pushed the fix-botocore-internal-api-usage branch from b2f3013 to 3358550 Compare December 23, 2022 12:21
@alexrashed alexrashed temporarily deployed to localstack-ext-tests December 23, 2022 12:21 — with GitHub Actions Inactive
@alexrashed alexrashed marked this pull request as ready for review December 23, 2022 12:21
thrau
thrau approved these changes Dec 23, 2022
View reviewed changes
Copy link
Member

@thrau thrau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 thanks for investigating and fixing

@thrau thrau merged commit 39ec690 into master Dec 23, 2022
@thrau thrau deleted the fix-botocore-internal-api-usage branch December 23, 2022 16:00
@bentsku bentsku mentioned this pull request Jul 11, 2023
Merged
@bentsku bentsku mentioned this pull request Oct 23, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thrau thrau thrau approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@alexrashed @bentsku @coveralls @thrau @steffyP