Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Adapt stream event source listeners for ASF lambda provider #7110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 18 commits into from
Nov 22, 2022

Conversation

dominikschubert
Copy link
Member

@dominikschubert dominikschubert commented Oct 28, 2022

Changes:

  • Adapter extended to work for Kinesis and DynamoDB Event Source Mappings (a bit dirty but didn't want to change the logic in the event source listeners for now)
  • SNS => Lambda invoke is now asynchronous (Event type)
  • Fixed physical resource ID and attributes for some cloudformation models
  • Removed config settings for SYNCHRONOUS_*_EVENTS. We should always use the proper invocation types here since a lot of additional logic depends on them (e.g. destinations). The config setting for KINESIS and SNS was kept for now since those were still used in the code. They're being deprecated are only available in the old provider until 2.0

Some cleanup/enhancements still open:

  • Use proper invoke and use the return code when passing payload to event source mapping destinations => after the initial parity release

@dominikschubert dominikschubert self-assigned this Oct 28, 2022
@dominikschubert dominikschubert temporarily deployed to localstack-ext-tests October 28, 2022 08:01 Inactive
@dominikschubert dominikschubert temporarily deployed to localstack-ext-tests October 28, 2022 09:01 Inactive
@github-actions
Copy link

github-actions bot commented Oct 28, 2022

LocalStack integration with Pro

       3 files  ±0         3 suites  ±0   1h 16m 59s ⏱️ - 3m 31s
1 488 tests +2  1 269 ✔️ +2  219 💤 ±0  0 ±0 
2 088 runs  +2  1 635 ✔️ +2  453 💤 ±0  0 ±0 

Results for commit cf99a4e. ± Comparison against base commit 260e374.

♻️ This comment has been updated with latest results.

@dominikschubert dominikschubert temporarily deployed to localstack-ext-tests October 28, 2022 13:20 Inactive
@dominikschubert dominikschubert force-pushed the lambda-eventsourcemapping-dynamodbkinesis branch from 9640654 to 719d4f5 Compare November 10, 2022 19:55
@dominikschubert dominikschubert temporarily deployed to localstack-ext-tests November 10, 2022 19:56 Inactive
@dominikschubert dominikschubert temporarily deployed to localstack-ext-tests November 10, 2022 20:10 Inactive
@dominikschubert dominikschubert temporarily deployed to localstack-ext-tests November 10, 2022 22:46 Inactive
@dominikschubert dominikschubert temporarily deployed to localstack-ext-tests November 11, 2022 01:02 Inactive
@dominikschubert dominikschubert temporarily deployed to localstack-ext-tests November 11, 2022 07:07 Inactive
@dominikschubert dominikschubert force-pushed the lambda-eventsourcemapping-dynamodbkinesis branch from 9075dd6 to 6a47038 Compare November 16, 2022 16:11
@dominikschubert dominikschubert temporarily deployed to localstack-ext-tests November 16, 2022 16:11 Inactive
@dominikschubert dominikschubert force-pushed the lambda-eventsourcemapping-dynamodbkinesis branch from 6a47038 to 02576af Compare November 16, 2022 16:15
@dominikschubert dominikschubert temporarily deployed to localstack-ext-tests November 16, 2022 16:15 Inactive
@dominikschubert dominikschubert marked this pull request as ready for review November 16, 2022 16:16
@dominikschubert dominikschubert force-pushed the lambda-eventsourcemapping-dynamodbkinesis branch from 02576af to 44d1dd3 Compare November 21, 2022 09:29
@dominikschubert dominikschubert temporarily deployed to localstack-ext-tests November 21, 2022 09:29 Inactive
@dominikschubert dominikschubert temporarily deployed to localstack-ext-tests November 21, 2022 22:27 Inactive
@dominikschubert dominikschubert force-pushed the lambda-eventsourcemapping-dynamodbkinesis branch from c62256d to 5783eee Compare November 22, 2022 05:46
@dominikschubert dominikschubert temporarily deployed to localstack-ext-tests November 22, 2022 05:46 Inactive
@dominikschubert dominikschubert temporarily deployed to localstack-ext-tests November 22, 2022 06:35 Inactive
@dominikschubert dominikschubert temporarily deployed to localstack-ext-tests November 22, 2022 08:13 Inactive
Copy link
Member

@thrau thrau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice PR! LGTM!

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.03%) to 82.817% when pulling cf99a4e on lambda-eventsourcemapping-dynamodbkinesis into 260e374 on master.

@dominikschubert dominikschubert merged commit 51b9788 into master Nov 22, 2022
@dominikschubert dominikschubert deleted the lambda-eventsourcemapping-dynamodbkinesis branch November 22, 2022 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants