Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix skip snapshot for s3 test #7111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 28, 2022
Merged

fix skip snapshot for s3 test #7111

merged 1 commit into from
Oct 28, 2022

Conversation

bentsku
Copy link
Contributor

@bentsku bentsku commented Oct 28, 2022

The CI just broke because of CORS headers for S3 requests with an allowed origin in LocalStack, a test was snapshotting all headers, which fails because AWS doesn't return CORS headers if not configured (but we need to for the web app and such).

\cc @steffyP

@bentsku bentsku requested a review from whummer October 28, 2022 15:34
@bentsku bentsku temporarily deployed to localstack-ext-tests October 28, 2022 15:35 Inactive
whummer
whummer approved these changes Oct 28, 2022
View reviewed changes
Copy link
Member

@whummer whummer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch! LGTM @bentsku 👍

Tricky one - for the record: the snapshot tests introduced in this PR are no longer valid. Even though the last builds (10 days ago) in this PR were green, those changes were now conflicting with the latest version on master.

@bentsku
Copy link
Contributor Author

bentsku commented Oct 28, 2022

Nice catch! LGTM @bentsku 👍

Tricky one - for the record: the snapshot tests introduced in this PR are no longer valid. Even though the last builds (10 days ago) in this PR were green, those changes were now conflicting with the latest version on master.

Thanks for the context! 🙏

@github-actions
Copy link

LocalStack integration with Pro

       3 files  +    2         3 suites  +2   1h 14m 38s ⏱️ + 28m 25s
1 430 tests +  16  1 242 ✔️ +  27  188 💤  -   10  0 ❌  - 1 
2 028 runs  +614  1 608 ✔️ +393  420 💤 +222  0 ❌  - 1 

Results for commit 87a6753. ± Comparison against base commit 86886d3.

@bentsku bentsku merged commit 1eb8ac5 into master Oct 28, 2022
@bentsku bentsku deleted the fix-s3-cors-snapshot branch October 28, 2022 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@whummer whummer whummer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bentsku @whummer