Lambda provider parity #7165
Merged
Lambda provider parity #7165
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 tasks
2813e32 to
31f7815
Compare
618ebe4 to
d290cfe
Compare
8451bd0 to
c012a0b
Compare
dd41102 to
c01e483
Compare
dominikschubert
commented
Nov 29, 2022
dominikschubert
commented
Nov 29, 2022
This reverts commit d41e88a.
5ff9e19 to
30774b3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When this PR is green the new provider can be assumed to cover the same features as the old one for all community features.
Note: The changes to the CI will be reverted and moved into #6724 . They are just needed to execute all tests in the context of the new ASF provider instead of just selected ones like we currently do in master. => circle CI config does not need to be reviewed
List of fixed tests
test_secretsmanager.py::TestSecretsManager::test_rotate_secret_with_lambda_1==> skipped for now since they need a reworktest_secretsmanager.py::TestSecretsManager::test_rotate_secret_with_lambda_2==> skipped for now since they need a reworktests/integration/test_stepfunctions.py::test_aws_sdk_tasktest_apigateway.py::TestAPIGateway::test_api_gateway_lambda_proxy_integration_any_method_with_path_paramtest_apigateway.py::TestAPIGateway::test_apigateway_with_lambda_integrationtest_apigateway.py::TestAPIGateway::test_apigateway_with_custom_authorization_methodtest_apigateway.py::TestAPIGateway::test_step_function_integrationstest_events.py::TestEvents::test_put_events_with_target_lambdatest_logs.py::TestCloudWatchLogs::test_put_subscription_filter_lambdatest_lambda_common.py::TestLambdaRuntimesCommon(java, dotnet, go, provided rust) ==> fixed by pre-building before running the teststest_serverless.py::TestServerless::test_dynamodb_stream_handler_deployedtest_serverless.py::TestServerless::test_kinesis_stream_handler_deployedtest_serverless.py::TestServerless::test_queue_handler_deployedtest_sam.py::test_sam_templatetest_security.py::TestCSRF::test_disable_cors_checkstest_lambda_legacy.pytest_lambda_whitebox.pytest_stepfunctions.py::test_nested_statemachine_with_sync2test_docker.py::TestDockerClient==> failing in the following constellation: docker socket available but docker client is not availabletest_lambda_destinations.py::TestLambdaDLQ::test_dead_letter_queuetest_dynamodb.py::TestDynamoDB::test_dynamodb_stream_to_lambdatestutil.create_lambda_functionis usedOther non-test-fix changes:
AWS::Lambda::Functionwaits for the function to be active before finishing the createaws-sdkgeneric stepfunctions task with the new Lambda provider.To be done in a follow-up: