Thanks to visit codestin.com
Credit goes to github.com

Skip to content

add S3 ASF test job to CircleCI workflow #7173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 17, 2022
Merged

Conversation

alexrashed
Copy link
Member

This PR adds a new parallel step to our CircleCI workflow to test the S3 ASF provider on every build.
It depends on #7081 (fixes the remaining tests for the new S3 ASF provider).
It should be reverted once the new S3 provider is default (such that the legacy provider is tested).
Finally, the tests should be removed when the legacy providers are removed.

@alexrashed alexrashed marked this pull request as ready for review November 17, 2022 08:27
@coveralls
Copy link

Coverage Status

Coverage increased (+3.3%) to 82.812% when pulling a0601ac on add-s3-asf-test-job into db7ab17 on master.

Copy link
Member

@steffyP steffyP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍 thanks for adding the s3-asf test to the workflow! 🙏

@alexrashed alexrashed merged commit 0bdfa27 into master Nov 17, 2022
@alexrashed alexrashed deleted the add-s3-asf-test-job branch November 17, 2022 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants