Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Add support for lambda timeouts #7180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Nov 15, 2022
Merged

Add support for lambda timeouts #7180

merged 4 commits into from
Nov 15, 2022

Conversation

dfangl
Copy link
Member

@dfangl dfangl commented Nov 15, 2022

Motivation

Implementing lambda timeouts, to achieve parity with AWS behavior.
This implementation only affects the new, ASF - based lambda provider.

Changes

  • Added test making assertions about the execution environment and infrastructure after a timeout
  • Update aws lambda init binary to 0.1.6-pre.

Most actual changes for this functionality happened in localstack/lambda-runtime-init#6 .

@dfangl dfangl temporarily deployed to localstack-ext-tests November 15, 2022 13:19 Inactive
@dfangl dfangl temporarily deployed to localstack-ext-tests November 15, 2022 14:44 Inactive
dominikschubert
dominikschubert approved these changes Nov 15, 2022
View reviewed changes
Copy link
Member

@dominikschubert dominikschubert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@github-actions
Copy link

LocalStack integration with Pro

       3 files  +    2         3 suites  +2   1h 13m 7s ⏱️ + 23m 30s
1 465 tests +  17  1 261 ✔️ +  36  204 💤  -     9  0 ❌ ±0 
2 065 runs  +617  1 627 ✔️ +402  438 💤 +225  0 ❌ ±0 

Results for commit 6810baa. ± Comparison against base commit 62502bf.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.005%) to 79.867% when pulling 6810baa on lambda-timeouts into 62502bf on master.

@dfangl dfangl merged commit f6aceef into master Nov 15, 2022
@dfangl dfangl deleted the lambda-timeouts branch November 15, 2022 16:50
@dfangl dfangl mentioned this pull request Nov 15, 2022
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dominikschubert dominikschubert dominikschubert approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dfangl @coveralls @dominikschubert