Port Lambda URL invocation support to ASF provider #7225
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dfangl
approved these changes
Nov 23, 2022
| @@ -1258,7 +1268,7 @@ def create_function_url_config( | |||
| function_name=function_name, | |||
| cors=cors, | |||
| url_id=url_id, | |||
| url=f"https://{url_id}.lambda-url.{context.region}.on.aws/", | |||
| url=f"http://{url_id}.lambda-url.{context.region}.{LOCALHOST_HOSTNAME}:{config.EDGE_PORT_HTTP or config.EDGE_PORT}/", # TODO: https support | |||
There was a problem hiding this comment.
We might want to make the LOCALHOST_HOSTNAME part configurable at some point, but should be fine for a first version.
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mostly C&P of existing code with the intention of decoupling it from the legacy provider since going forward changes should be focused on the ASF provider anyway and some of the mapping concepts don't apply anymore.
Also: