Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Add support for nodejs 18.x runtime to ASF lambda provider #7234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 23, 2022
Merged

Add support for nodejs 18.x runtime to ASF lambda provider #7234

merged 2 commits into from
Nov 23, 2022

Conversation

dfangl
Copy link
Member

@dfangl dfangl commented Nov 23, 2022

Addresses #7209

Motivation

Lambda recently added support for nodejs18.x runtime: https://aws.amazon.com/blogs/compute/node-js-18-x-runtime-now-available-in-aws-lambda/

Changes

  • Add support for nodejs18.x runtime
  • Add tests for nodejs18.x runtime
  • Update snapshots
  • Update images for nodejs14.x and nodejs16.x to achieve parity with recent lambda env changes (AWS updated the images on their side as well - see new line numbers in error handling snapshot)

@dfangl dfangl temporarily deployed to localstack-ext-tests November 23, 2022 11:14 Inactive
dominikschubert
dominikschubert approved these changes Nov 23, 2022
View reviewed changes
Copy link
Member

@dominikschubert dominikschubert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (+ 1 question)

@dfangl dfangl temporarily deployed to localstack-ext-tests November 23, 2022 12:41 Inactive
@github-actions
Copy link

LocalStack integration with Pro

       3 files  ±0         3 suites  ±0   1h 26m 10s ⏱️ +52s
1 492 tests +3  1 268 ✔️ ±0  224 💤 +3  0 ❌ ±0 
2 100 runs  +9  1 634 ✔️ ±0  466 💤 +9  0 ❌ ±0 

Results for commit 6334fb9. ± Comparison against base commit d3e72e3.

@dfangl dfangl mentioned this pull request Nov 23, 2022
Merged
10 tasks
@dfangl dfangl merged commit 1328977 into master Nov 23, 2022
@dfangl dfangl deleted the lambda-nodejs-18 branch November 23, 2022 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dominikschubert dominikschubert dominikschubert approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dfangl @dominikschubert