Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Add support for Lambda asynchronous event retries #7259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 17 commits into from
Dec 20, 2022
Merged

Add support for Lambda asynchronous event retries #7259

merged 17 commits into from
Dec 20, 2022

Conversation

dominikschubert
Copy link
Member

@dominikschubert dominikschubert commented Nov 29, 2022 •
edited
Loading

Changes

  • Add support for configuring max retry attempts at 0,1 or 2 for asynchronous invocations. The first retry attempt will be delayed by 60s, the second one by 120s. To avoid having this test run for 3min+ a config was introduced to configure the base delay and scale the second one (2x)
  • Add support for configuring a maximum event age. If the invoke would take place at a time later than that event age it will not be rescheduled for a retry.
  • Add typing for retry util
  • Improve event invoke config tests

@dominikschubert dominikschubert self-assigned this Nov 29, 2022
@dominikschubert dominikschubert temporarily deployed to localstack-ext-tests November 29, 2022 10:05 Inactive
@dominikschubert dominikschubert temporarily deployed to localstack-ext-tests November 29, 2022 10:06 Inactive
@dominikschubert dominikschubert temporarily deployed to localstack-ext-tests November 29, 2022 10:25 Inactive
@dominikschubert dominikschubert temporarily deployed to localstack-ext-tests November 29, 2022 11:06 Inactive
@coveralls
Copy link

coveralls commented Nov 29, 2022 •
edited
Loading

Coverage Status

Coverage decreased (-0.04%) to 84.802% when pulling 2dfa6fc on feat_lambda-retries into 01132f3 on master.

@github-actions
Copy link

github-actions bot commented Nov 29, 2022 •
edited
Loading

LocalStack integration with Pro

       3 files  ±  0         3 suites  ±0   1h 25m 34s ⏱️ + 4m 42s
1 573 tests +  5  1 300 ✔️ +1  273 💤 +  4  0 ❌ ±0 
2 217 runs  +15  1 668 ✔️ +1  549 💤 +14  0 ❌ ±0 

Results for commit 2dfa6fc. ± Comparison against base commit 01132f3.

♻️ This comment has been updated with latest results.

@dominikschubert dominikschubert temporarily deployed to localstack-ext-tests November 30, 2022 12:16 Inactive
@dominikschubert dominikschubert temporarily deployed to localstack-ext-tests November 30, 2022 12:40 Inactive
@dominikschubert dominikschubert temporarily deployed to localstack-ext-tests December 16, 2022 11:15 — with GitHub Actions Inactive
@dominikschubert dominikschubert temporarily deployed to localstack-ext-tests December 16, 2022 13:14 — with GitHub Actions Inactive
@dominikschubert dominikschubert temporarily deployed to localstack-ext-tests December 16, 2022 14:16 — with GitHub Actions Inactive
@dominikschubert dominikschubert temporarily deployed to localstack-ext-tests December 16, 2022 14:38 — with GitHub Actions Inactive
@dominikschubert dominikschubert temporarily deployed to localstack-ext-tests December 16, 2022 18:47 — with GitHub Actions Inactive
@dominikschubert dominikschubert temporarily deployed to localstack-ext-tests December 16, 2022 19:29 — with GitHub Actions Inactive
@dominikschubert dominikschubert marked this pull request as ready for review December 16, 2022 20:16
@dominikschubert dominikschubert temporarily deployed to localstack-ext-tests December 16, 2022 21:40 — with GitHub Actions Inactive
dfangl
dfangl approved these changes Dec 19, 2022
View reviewed changes
Copy link
Member

@dfangl dfangl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just some minor test suggestion.

tests/integration/awslambda/test_lambda_api.py

# publish a version so we can have more than one entries for list ops
publish_version_result = lambda_client.publish_version(FunctionName=function_name)
snapshot.match("publish_version_result", publish_version_result)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A get_function_event_invoke_config right after the publish, on the published version would be interesting. To verify if it sticks / has to be recreated.

@dominikschubert dominikschubert temporarily deployed to localstack-ext-tests December 19, 2022 13:20 — with GitHub Actions Inactive
@dominikschubert dominikschubert merged commit 63abd3e into master Dec 20, 2022
@dominikschubert dominikschubert deleted the feat_lambda-retries branch December 20, 2022 06:01
@dfangl dfangl mentioned this pull request Dec 23, 2022
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dfangl dfangl dfangl approved these changes

@steffyP steffyP Awaiting requested review from steffyP

@thrau thrau Awaiting requested review from thrau

Assignees

@dominikschubert dominikschubert

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dominikschubert @coveralls @dfangl