Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Support lambda docker flags in the asf provider #7379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 21, 2022
Merged

Support lambda docker flags in the asf provider #7379

merged 2 commits into from
Dec 21, 2022

Conversation

dfangl
Copy link
Member

@dfangl dfangl commented Dec 21, 2022

Motivation

We already got multiple requests (e.g. https://discuss.localstack.cloud/t/nodejs-remote-debugging-with-provider-override-lambda-asf/185/2) for the flag to be supported again, as it is used in multiple debugging setups.

Changes

  • Allow lambda docker flags to be present again
  • Add test to developer tools which verifies the correct usage (of at least the environment flag)

@dfangl dfangl temporarily deployed to localstack-ext-tests December 21, 2022 17:14 — with GitHub Actions Inactive
dominikschubert
dominikschubert approved these changes Dec 21, 2022
View reviewed changes
Copy link
Member

@dominikschubert dominikschubert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to keep this option 👍

@dfangl dfangl temporarily deployed to localstack-ext-tests December 21, 2022 18:15 — with GitHub Actions Inactive
@coveralls
Copy link

Coverage Status

Coverage increased (+0.1%) to 84.855% when pulling d83a540 on lambda-docker-flags into 05aa390 on master.

@github-actions
Copy link

LocalStack integration with Pro

1 559 tests  +1   1 273 ✔️  - 1   1h 2m 56s ⏱️ - 2m 45s
       1 suites ±0      285 💤 +2 
       1 files   ±0          1 ❌ ±0 

For more details on these failures, see this check.

Results for commit d83a540. ± Comparison against base commit 05aa390.

@dfangl dfangl merged commit 09ce620 into master Dec 21, 2022
@dfangl dfangl deleted the lambda-docker-flags branch December 21, 2022 20:38
@dfangl dfangl mentioned this pull request Dec 23, 2022
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dominikschubert dominikschubert dominikschubert approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dfangl @coveralls @dominikschubert