Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix naming from Lambda revisions PR #7551

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 25, 2023
Merged

Fix naming from Lambda revisions PR #7551

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 12 additions & 12 deletions localstack/services/awslambda/provider.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1756,13 +1756,13 @@ def add_permission(
# TODO: re-evaluate data model to prevent this dirty hack just for bumping the revision id
# TODO: does that need a `with function.lock` for atomic updates of the policy + revision_id?
if api_utils.qualifier_is_alias(resolved_qualifier):
latest_alias = resolved_fn.aliases[resolved_qualifier]
resolved_fn.aliases[resolved_qualifier] = dataclasses.replace(latest_alias)
resolved_alias = resolved_fn.aliases[resolved_qualifier]
resolved_fn.aliases[resolved_qualifier] = dataclasses.replace(resolved_alias)
# Assumes that a non-alias is a version
else:
latest_version = resolved_fn.versions[resolved_qualifier]
resolved_version = resolved_fn.versions[resolved_qualifier]
resolved_fn.versions[resolved_qualifier] = dataclasses.replace(
latest_version, config=dataclasses.replace(latest_version.config)
resolved_version, config=dataclasses.replace(resolved_version.config)
)
return AddPermissionResponse(Statement=json.dumps(permission_statement))

Expand Down Expand Up @@ -1819,13 +1819,13 @@ def remove_permission(
# TODO: re-evaluate data model to prevent this dirty hack just for bumping the revision id
# TODO: does that need a `with function.lock` for atomic updates of the policy + revision_id?
if api_utils.qualifier_is_alias(resolved_qualifier):
latest_alias = resolved_fn.aliases[resolved_qualifier]
resolved_fn.aliases[resolved_qualifier] = dataclasses.replace(latest_alias)
resolved_alias = resolved_fn.aliases[resolved_qualifier]
resolved_fn.aliases[resolved_qualifier] = dataclasses.replace(resolved_alias)
# Assumes that a non-alias is a version
else:
latest_version = resolved_fn.versions[resolved_qualifier]
resolved_version = resolved_fn.versions[resolved_qualifier]
resolved_fn.versions[resolved_qualifier] = dataclasses.replace(
latest_version, config=dataclasses.replace(latest_version.config)
resolved_version, config=dataclasses.replace(resolved_version.config)
)

# remove the policy as a whole when there's no statement left in it
Expand Down Expand Up @@ -1856,12 +1856,12 @@ def get_policy(

fn_revision_id = None
if api_utils.qualifier_is_alias(resolved_qualifier):
latest_alias = resolved_fn.aliases[resolved_qualifier]
fn_revision_id = latest_alias.revision_id
resolved_alias = resolved_fn.aliases[resolved_qualifier]
fn_revision_id = resolved_alias.revision_id
# Assumes that a non-alias is a version
else:
latest_version = resolved_fn.versions[resolved_qualifier]
fn_revision_id = latest_version.config.revision_id
resolved_version = resolved_fn.versions[resolved_qualifier]
fn_revision_id = resolved_version.config.revision_id

return GetPolicyResponse(
Policy=json.dumps(dataclasses.asdict(function_permission.policy)),
Expand Down