Set download retries and log download exceptions for installer failures #7600
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexrashed
approved these changes
Feb 3, 2023
baermat
approved these changes
Feb 3, 2023
There was a problem hiding this comment.
Mostly LGTM 👍 I agree with what @alexrashed said, + one small thing that I wanted to clarify (but is not blocking in any way)
Comment on lines
+208
to
+209
| if os.path.getsize(tmp_archive) <= 0: | ||
| raise Exception("Failed to download archive from %s: . Retries exhausted", archive_url) |
There was a problem hiding this comment.
question: can this actually ever be a negative value? The docs state that in case of inaccessibility, OSError is returned.
There was a problem hiding this comment.
TBH, just copied this from L185.
Like you said, probably not, but I guess we still wouldn't want it if for some reason this would happen on some esoteric system 🤷♂️
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
PR was motivated by failing downloads of ffmpeg where the Installer tries to extract the empty installer file instead of just re-trying to download the archive first. It also didn't log any meaningful exceptions in this case since it wasn't a
requests.exceptions.ReadTimeoutChanges