Thanks to visit codestin.com
Credit goes to github.com

Skip to content

remove dead legacy edge proxy code #7683

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

remove dead legacy edge proxy code #7683

wants to merge 2 commits into from

Conversation

thrau
Copy link
Member

@thrau thrau commented Feb 14, 2023

This PR removes chunks of the legacy edge proxy code that are no longer in use.

It's a draft PR to see based on the code coverage which parts we can remove. Currently it just removes tests that explicitly test parts of the edge proxy.

@thrau thrau temporarily deployed to localstack-ext-tests February 14, 2023 13:58 — with GitHub Actions Inactive
@github-actions
Copy link

github-actions bot commented Feb 14, 2023 •
edited
Loading

LocalStack integration with Pro

       3 files  ±  0         3 suites  ±0   1h 30m 56s ⏱️ + 1m 6s
1 711 tests  - 16  1 355 ✔️  - 13  356 💤  - 3  0 ❌ ±0 
2 425 runs   - 16  1 729 ✔️  - 13  696 💤  - 3  0 ❌ ±0 

Results for commit dc9cdff. ± Comparison against base commit 7159b90.

♻️ This comment has been updated with latest results.

@alexrashed alexrashed force-pushed the remove-legacy-edge-proxy branch from 8061b6c to 65bbf6f Compare February 16, 2023 08:16
@alexrashed alexrashed temporarily deployed to localstack-ext-tests February 16, 2023 08:16 — with GitHub Actions Inactive
@thrau thrau force-pushed the remove-legacy-edge-proxy branch from 65bbf6f to dc9cdff Compare February 16, 2023 11:56
@thrau thrau temporarily deployed to localstack-ext-tests February 16, 2023 11:56 — with GitHub Actions Inactive
@coveralls
Copy link

coveralls commented Feb 16, 2023 •
edited
Loading

Coverage Status

coverage: 80.018% (-2.2%) from 82.198% when pulling 9efa19c on remove-legacy-edge-proxy into e04eeb2 on master.

@alexrashed alexrashed force-pushed the remove-legacy-edge-proxy branch from dc9cdff to 693626f Compare July 12, 2023 13:58
@alexrashed alexrashed added this to the 3.0 milestone Jul 12, 2023
@alexrashed alexrashed added the semver: major Breaking changes which can be included in a major release only label Jul 12, 2023
@localstack-bot
Copy link
Contributor

Currently, only minor and patch changes are allowed on master. Your PR labels (semver: major) indicate that it cannot be merged into the master at this time.

@alexrashed
Copy link
Member

FYI @thrau: I rebased this PR and added a new commit which:

  • Removes the legacy tests
  • Removes the legacy providers
  • Removes the AwsApiListener bridge to the ProxyListener

@alexrashed alexrashed force-pushed the remove-legacy-edge-proxy branch from 693626f to b98942c Compare July 12, 2023 14:47
@alexrashed alexrashed force-pushed the remove-legacy-edge-proxy branch from b98942c to 9efa19c Compare July 12, 2023 15:28
@github-actions
Copy link

LocalStack Community integration with Pro

       2 files         2 suites   1h 24m 14s ⏱️
2 220 tests 1 888 ✔️ 332 💤 0 ❌
2 221 runs  1 888 ✔️ 333 💤 0 ❌

Results for commit 9efa19c.

@alexrashed alexrashed self-assigned this Aug 1, 2023
@alexrashed
Copy link
Member

Closing this since it has been superseded by #9581.

@alexrashed alexrashed closed this Nov 14, 2023
@alexrashed alexrashed deleted the remove-legacy-edge-proxy branch November 17, 2023 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@alexrashed alexrashed

Labels
semver: major Breaking changes which can be included in a major release only
Projects
None yet
Milestone
3.0
Development

Successfully merging this pull request may close these issues.
4 participants
@thrau @coveralls @localstack-bot @alexrashed