Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Add SourceArn for Events Message Publisher #8217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
May 4, 2023
Merged

Add SourceArn for Events Message Publisher #8217

merged 5 commits into from
May 4, 2023

Conversation

pinzon
Copy link
Member

@pinzon pinzon commented Apr 27, 2023 •
edited
Loading

This PR makes the Events service provider pass the RuleArn to the send_event_to_target function. Now the function can put the correct value on the request metadata for the new internal clients.

Changes:

  • Source ARN for Not Scheduled events
  • Source ARN for Scheduled Events
  • Scheduled events now handle alternate event buses this should not be possible for parity sake

@github-actions
Copy link

github-actions bot commented Apr 27, 2023 •
edited
Loading

LocalStack Community integration with Pro

1 997 tests   1 730 ✔️  1h 10m 36s ⏱️
       2 suites     265 💤
       2 files           2 ❌

For more details on these failures, see this check.

Results for commit b3926e1.

♻️ This comment has been updated with latest results.

@pinzon pinzon force-pushed the test_events-sqs-iam branch from 036b8ba to f5f844d Compare May 2, 2023 19:03
@pinzon pinzon marked this pull request as ready for review May 3, 2023 13:11
dfangl
dfangl requested changes May 3, 2023
View reviewed changes
Copy link
Member

@dfangl dfangl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some minor nits.
I think it would be nice to have some tests for the "Scheduled events now handle alternate event buses" part of the PR though, which seems like a great addition/fix!

@dfangl dfangl added the semver: patch Non-breaking changes which can be included in patch releases label May 3, 2023
@pinzon pinzon requested a review from dfangl May 3, 2023 17:54
@pinzon
Copy link
Member Author

pinzon commented May 3, 2023 •
edited
Loading

@dfangl. while writing the test for alternate event buses I learnt that scheduled expressions are not supported by buses other than the default. So I restored that part of the code.

dfangl
dfangl approved these changes May 4, 2023
View reviewed changes
Copy link
Member

@dfangl dfangl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for verifying the changes for scheduled rules. The test failures are fixed by #8251, so no reason to hold back the merge.

@pinzon pinzon merged commit b4bc83f into master May 4, 2023
@alexrashed alexrashed deleted the test_events-sqs-iam branch November 28, 2023 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dfangl dfangl dfangl approved these changes

@dominikschubert dominikschubert Awaiting requested review from dominikschubert

Assignees
No one assigned
Labels
semver: patch Non-breaking changes which can be included in patch releases
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pinzon @dfangl