remove pin on botocore #8321
remove pin on botocore #8321
Conversation
|
Unfortunately, the upgrade introduces a new issue. It seems that the issue is caused by The issue is a bit weird though. The URL path parameter is now weirdly encoded. The request generated in the following lines changed: localstack/tests/integration/test_moto.py Lines 344 to 346 in d8a2f65 It now contains the url encoded prefix of the ID instead of: Edit: |
A recent community contribution was aiming at removing the upper version pin on
botocore(#8210, thanks @matt-mercer!). Unfortunately, the latest release at the time contained an invalid spec which was reported in boto/botocore#2925.The latest release of
botocorenow contains the requested fixes to the kafka service specs: boto/botocore@8bd1a4dThis is why we can finally remove the pin again.
In the future we might introduce an automate approach (using dependabot or similar bots) to explicitly upgrade these core libraries on a fixed schedule (to move more towards a proactive approach instead of the currently rather reactive approach when new releases of these libraries - like werkzeug or botocore - break our builds).
With #8307 we also moved
botocoreandboto3from the install dependencies to the runtime extra (aka from a CLI dependency to a runtime dependency, which allows us to be more restrictive with the pins since the CLI dependencies have a wider impact compared to the runtime dependencies which are usually only used within our Docker images).