Thanks to visit codestin.com
Credit goes to github.com

Skip to content

remove pin on botocore #8321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 17, 2023
Merged

remove pin on botocore #8321

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6dbeec8
remove pin on botocore after kafka spec fixes
alexrashed May 16, 2023
d13a19e
fix param pre-processing for forwarder after botocore upgrade
alexrashed May 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions localstack/aws/forwarder.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,6 +175,8 @@ def create_aws_request_context(
# The endpoint URL is mandatory here, set a dummy if not given (doesn't _need_ to be localstack specific)
if not endpoint_url:
endpoint_url = "http://localhost.localstack.cloud"
# pre-process the request args (some params are modified using botocore event handlers)
parameters = client._emit_api_params(parameters, operation, request_context)
request_dict = client._convert_to_request_dict(
parameters, operation, endpoint_url, context=request_context
)
Expand Down
2 changes: 1 addition & 1 deletion setup.cfg
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ runtime =
awscrt>=0.13.14
boto>=2.49.0
boto3>=1.26.121
botocore>=1.29.121,<=1.29.121
botocore>=1.29.133
cbor2>=5.2.0
crontab>=0.22.6
dnslib>=0.9.10
Expand Down
2 changes: 2 additions & 0 deletions tests/unit/aws/test_service_router.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,6 +172,8 @@ def test_service_router_works_for_every_service(
}
request_args = _create_dummy_request_args(operation)

# pre-process the request args (some params are modified using botocore event handlers)
request_args = client._emit_api_params(request_args, operation, request_context)
# The endpoint URL is mandatory here, just set a dummy (doesn't _need_ to be localstack specific)
request_dict = client._convert_to_request_dict(
request_args, operation, "http://localhost.localstack.cloud", request_context
Expand Down