Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows the user to configure a "managed" docker network.
Putting containers on the same docker network means more straightforward configuration. The containers can make requests to each other using their container names. LocalStack currently adds configuration to allow the user to specify which docker network to add created containers to, for services such as Lambda or ECS. This requires:
Instead, let's make LocalStack the curator of this docker network. On startup, create a named network (if it doesn't exist) and add all containers to it for the user. This means:
Users using docker compose will see the example compose file in the repo and replicate the behaviour in their own compose files.
Implementation
We use the existing configuration variables to control the networks of created containers, and add new configuration to override their behaviour. When the CLI starts up, we create the network if it doesn't exist.
Questions
USE_MANAGED_DOCKER_NETWORK
lines?