Thanks to visit codestin.com
Credit goes to github.com

Skip to content

WIP: Lambda invocation loop rework #8508

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 61 commits into from
Closed

WIP: Lambda invocation loop rework #8508

wants to merge 61 commits into from

Conversation

dominikschubert
Copy link
Member

@dominikschubert dominikschubert commented Jun 15, 2023 •
edited by joe4dev
Loading

@dominikschubert dominikschubert added the semver: minor Non-breaking changes which can be included in minor releases, but not in patch releases label Jun 15, 2023
@dominikschubert dominikschubert force-pushed the lambda-invocation-loop-rework branch from ea563d0 to 4fb0409 Compare July 11, 2023 09:06
@dominikschubert dominikschubert added this to the 3.0 milestone Jul 12, 2023
@joe4dev joe4dev force-pushed the lambda-invocation-loop-rework branch 3 times, most recently from b769c9d to d476257 Compare August 8, 2023 10:17
@joe4dev joe4dev force-pushed the lambda-invocation-loop-rework branch 2 times, most recently from 473a900 to 9a161c3 Compare August 10, 2023 11:16
@github-actions
Copy link

github-actions bot commented Aug 10, 2023 •
edited
Loading

LocalStack Community integration with Pro

       2 files         2 suites   1h 25m 16s ⏱️
2 113 tests 1 664 ✔️ 448 💤 1 ❌
2 114 runs  1 664 ✔️ 449 💤 1 ❌

For more details on these failures, see this check.

Results for commit cb21d7f.

♻️ This comment has been updated with latest results.

@joe4dev joe4dev force-pushed the lambda-invocation-loop-rework branch from 9a161c3 to 9afa186 Compare August 10, 2023 12:12
joe4dev and others added 26 commits August 23, 2023 10:27
@joe4dev
Stop event manager and handle exception cases
15ef084
@joe4dev
Fix event source listener callback
d97339c
@joe4dev
Fix SQS => Lambda DLQ test by reducing retries
0a6fb31
@joe4dev
Fix service exception types
b879880
@joe4dev
Fix stopping Lambda environment for provisioned concurrency
c1a21a0
@joe4dev
Draft locking design
1699a3e
@dfangl @joe4dev
readd shutdown, refactor counting service to allow locking
4579a7a
@joe4dev
Fix warn logging deprecations
2a44107
@joe4dev
Remove implemented event manager todo.py
d287c4a
@joe4dev
Fix Lambda => SNS DLQ => SQS test by reducing Lambda retries
460c678 
The previous version of the test assumed that every failing Lambda invocation triggers the DLQ.
However, that only happends if the maximum number of retries are exhausted.
Adjusting the number of retries speeds up and fixes this test.
@joe4dev
Fix provisioned concurrency tests and exceptions
e9ad77c
@joe4dev
Re-activate other AWS tests
b762929
@joe4dev
Fix concurrency quota assumptions for provisioned concurrency test
fd2c662
@joe4dev
Fix limits testing for reserved concurrency
8ccbaa6 
The goal is to minimize the number of tests that require custom AWS quota adjustments.

* Separated limits testing because monkeypatching allows edge case testing with LocalStack.
* Fixed the scenario `put_function_concurrency_qualified_arn_exc`, which accidentially suffered from another AWS account-specific limits snapshot.
@joe4dev
Re-enable all tests
ff2fa93 
Revert CI config to master
@joe4dev
Add more logging info for Lambda poller shutdown error
e0f4057
@joe4dev
Add test for invoking non-existing function
9642b84
@joe4dev
Fix locking scope and cleanup concurrency tracking
80abdf3
@joe4dev
Remove draft of irrelevant counting service view
064ae15
@joe4dev
Remove dead code in lambda service
4548ca1
@joe4dev
Fix snapshot skips for old provider
19cd208
@joe4dev
Remove planning notes file
a4bfe09
@joe4dev
Fix init lock and exception handling
5968ced
@joe4dev
Skip failing SQS DLQ test for old provider
11fea6f
@joe4dev
Fixing poller shutdown (WIP)
aebad97
@dfangl @joe4dev
add more debug output, reorder to avoid missing cleanups
cb21d7f
@joe4dev joe4dev force-pushed the lambda-invocation-loop-rework branch from 35b62e8 to cb21d7f Compare August 23, 2023 08:47
@joe4dev
Copy link
Member

joe4dev commented Aug 23, 2023

will re-open as a separate one

@joe4dev joe4dev closed this Aug 23, 2023
@joe4dev
Copy link
Member

joe4dev commented Aug 23, 2023

as discussed with @dominikschubert and @dfangl , closed in favor of #8970

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bentsku bentsku Awaiting requested review from bentsku bentsku will be requested when the pull request is marked ready for review bentsku is a code owner

@baermat baermat Awaiting requested review from baermat baermat will be requested when the pull request is marked ready for review baermat is a code owner

@joe4dev joe4dev Awaiting requested review from joe4dev joe4dev will be requested when the pull request is marked ready for review joe4dev is a code owner

@dfangl dfangl Awaiting requested review from dfangl dfangl will be requested when the pull request is marked ready for review dfangl is a code owner

@gregfurman gregfurman Awaiting requested review from gregfurman gregfurman will be requested when the pull request is marked ready for review gregfurman is a code owner

Assignees

@dominikschubert dominikschubert

@joe4dev joe4dev

@dfangl dfangl

Labels
semver: minor Non-breaking changes which can be included in minor releases, but not in patch releases
Projects
None yet
Milestone
3.0
Development

Successfully merging this pull request may close these issues.
3 participants
@dominikschubert @joe4dev @dfangl