use ContainerConfiguration object for LocalstackContainer #8771
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
dfangl
approved these changes
Jul 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
There was a long standing TODO in the
LocalstackContainerclass:# TODO merge with docker_utils.py:ContainerConfiguration, which this PR fixes. This will be useful as we use theLocalstackContainerobject as an abstraction for the bootstrap tests (cc @simonrw).Also, I want to add some flags to the
localstack startcommand (like--networkto specify the container network the container should be started in), and this will make it a bit cleaner to do that.Changes
def run_container_from_config(self, container_config: ContainerConfiguration) -> Tuple[bytes, bytes]:to container client. adapted from the already existingcreate_container_from_configLocalstackContainerto use theContainerConfigurationobject internally to hold its configurationLocalstackContaineras properties. This way it's also fully compatible with the ext container hooks and requires no changes there. Theadditional_flagsthing is a bit of a mess.