Add bootstrap fixture for bootstrap tests #8781
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f83464f to
48887a4
Compare
bca3962 to
e768840
Compare
a461ee0 to
3aee5e6
Compare
6ba7e0c to
62108a7
Compare
d4082e5 to
09d4b8b
Compare
90200c3 to
c9617c9
Compare
3f80d28 to
02ffe32
Compare
thrau
requested changes
Aug 30, 2023
There was a problem hiding this comment.
Great set of refactorings! I have a few comments which are mostly minor. I wanted to just clarify where we stand on the issue of passing ContainerConfiguration to the hooks or rather stick with the Container. Should be reconciled with #8890
Comment on lines
+548
to
+549
| if not isinstance(self.container, RunningContainer): | ||
| raise ValueError(f"Container {self.container} not started") |
There was a problem hiding this comment.
this should be done by overriding the shutdown method otherwise the server will be in a wonky state (see the shutdown method implementation)
There was a problem hiding this comment.
I've pulled the check outside the do_shutdown method so we dont mess with the threading.event` variables: f341355 - is that what you were getting at?
I think the environment section is set up separately to the main invocation, which in turn sources the tinybird parameters
This should prevent the duplicate fixtures problem
Co-authored-by: Thomas Rausch <[email protected]>
This is annoying as we don't have a nice type system *cough* rust *cough*
thrau
approved these changes
Sep 1, 2023
tests/bootstrap/conftest.py
Outdated
| def _wait_for(container: RunningContainer, timeout: float | None = None): | ||
| container.wait_until_ready(timeout) | ||
|
|
||
| poll_condition(lambda: constants.READY_MARKER_OUTPUT in container.get_logs().splitlines()) |
There was a problem hiding this comment.
should we add the timeout here as well just to be sure?
There was a problem hiding this comment.
Good spot, thanks will do 👍
This was referenced Sep 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a fixture (and example tests) for black-box testing the LS container. Particularly: starting the container with different configurations and ensuring that it behaves as expected.
This fixture will be useful for: